Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in graph.maximum_average_degree #35533

Merged
merged 2 commits into from
Apr 23, 2023
Merged

Fix bug in graph.maximum_average_degree #35533

merged 2 commits into from
Apr 23, 2023

Conversation

dcoudert
Copy link
Contributor

Fixes #35532.

📚 Description

Fix corner cases (empty graph, graph without edges) in graph.maximum_average_degree.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@dcoudert dcoudert self-assigned this Apr 18, 2023
@dcoudert dcoudert requested a review from tscrim April 18, 2023 14:19
tscrim
tscrim requested changes Apr 19, 2023
View reviewed changes
src/sage/graphs/graph.py Outdated Show resolved Hide resolved
@dcoudert @tscrim
Update src/sage/graphs/graph.py
dcddb70 
Accept suggestion of the referee.

Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
tscrim
tscrim approved these changes Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@tscrim tscrim added this to the sage-10.0 milestone Apr 19, 2023
@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: dcddb70

@vbraun vbraun merged commit 133a345 into sagemath:develop Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

Assignees

@dcoudert dcoudert

Labels
c: graph theory t: bug
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging this pull request may close these issues.

ZeroDivisionError in graph.maximum_average_degree for the empty graph
4 participants
@dcoudert @tscrim @vbraun @mkoeppe