Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update openssl to 3.0.8 #35571

Merged
merged 1 commit into from
May 12, 2023
Merged

update openssl to 3.0.8 #35571

merged 1 commit into from
May 12, 2023

Conversation

dimpase
Copy link
Member

@dimpase dimpase commented Apr 26, 2023

from sage-devel by Thierry: I took his branch and made this PR from it.

Sage's current openssl version (3.0.5) hass several "High severity"
vulnerabilities, see https://www.openssl.org/news/vulnerabilities.html

It would be nice to have the fixes included in the next Sage release. I am not
using github, here is a pull request (literally) to fix this :

git pull https://lipn.univ-paris13.fr/~monteil/hebergement/sage/sage.git openssl.3.0.8

(commit hash : 997a6bd)
I checked the hash of the tarballs against the GPG signatures by upstream developers.

Tarball at : https://www.openssl.org/source/openssl-3.0.8.tar.gz

Ciao,
Thierry

P.S. Note that 3.1.0. has been very recently released, however 3.0.x is LTS and will
not have structural changes. Just in case, here is a verified branch :

git pull https://lipn.univ-paris13.fr/~monteil/hebergement/sage/sage.git openssl.3.1.0

(commit hash : 9229a2be66dc0e4f2e3f677aa515a33bfe72a873)
Tarball at : https://www.openssl.org/source/openssl-3.1.0.tar.gz

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 26, 2023

Run ci-linux workflow?

@dimpase
Copy link
Member Author

dimpase commented Apr 26, 2023

Run ci-linux workflow?

I don't know how to do this - it's not a named branch, I don't see how to trigger it (at least not from the browser)

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 26, 2023

It is named in your repo, where you can run it. It's called ssl308.

@dimpase
Copy link
Member Author

dimpase commented Apr 26, 2023

OK, running https://github.com/dimpase/sage/actions/runs/4810927760
(I know that some of our workflows on work here, not in forks)

@dimpase
Copy link
Member Author

dimpase commented Apr 26, 2023

So you see, https://github.com/dimpase/sage/actions/runs/4810927760 failed all jobs due to some Docker blah or whatever.

@dimpase
Copy link
Member Author

dimpase commented Apr 26, 2023

needless to say, it works otherwsie...

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 26, 2023

Try with #35417 merged

@dimpase
Copy link
Member Author

dimpase commented Apr 26, 2023

Try with #35417 merged

I understand it still won't fly.

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 26, 2023

Depends on your config; it sure works for me

@dimpase
Copy link
Member Author

dimpase commented Apr 26, 2023

well, as it all happens on GitHub, I have no idea how our forks are different.

@dimpase
Copy link
Member Author

dimpase commented May 3, 2023

No problem because I know. [...]

this link has pages and pages of verbose instructions. Presumably you figured it out - then it should go to a wiki or to a manual, what precisely has to be set.

@github-actions
Copy link

github-actions bot commented May 3, 2023

Documentation preview for this PR is ready! 🎉
Built with commit: c046024

@mkoeppe
Copy link
Contributor

mkoeppe commented May 3, 2023

it should go to a wiki or to a manual, what precisely has to be set

yes, that's #35108

@mkoeppe
Copy link
Contributor

mkoeppe commented May 8, 2023

@dimpase with the new version of #35108 users no longer need to adjust the permission settings

@mkoeppe
Copy link
Contributor

mkoeppe commented May 9, 2023

I've tested it on a few platforms in https://github.com/mkoeppe/sage/actions/runs/4922782397 (using #35380). It seems fine.

@mkoeppe mkoeppe added this to the sage-10.0 milestone May 9, 2023
@vbraun vbraun merged commit 49e5c41 into sagemath:develop May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants