sage.geometry: Add some # optional, reformat doctests
#35586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwankyu
reviewed
May 23, 2023
kwankyu
reviewed
May 23, 2023
| sage: p600 = polytopes.six_hundred_cell(exact=True) # not tested - very long time # optional - sage.groups | ||
| sage: len(list(p600.bounded_edges())) # not tested - very long time # optional - sage.groups | ||
| sage: p600 = polytopes.six_hundred_cell(exact=True) # not tested - very long time, optional - sage.groups | ||
| sage: len(list(p600.bounded_edges())) # not tested - very long time, optional - sage.groups | ||
| 720 |
There was a problem hiding this comment.
Now we have two formats # ... # optional - ..., # ..., optional - ... for the same thing?
I prefer the second format (changed mind after second look).
So, OK.
There was a problem hiding this comment.
I'm using the second format here because there were no alignment opportunities.
|
Otherwise, except Build & Test, it looks good to me. |
|
Now tests are passing |
kwankyu
reviewed
May 24, 2023
| @@ -1684,7 +1684,7 @@ def _contains(self, point, region='whole cone'): | |||
| sage: c = Cone([(1,0), (0,1)]) | |||
| sage: c._contains((1,I)) # optional - sage.symbolic | |||
| False | |||
| sage: c._contains(vector(QQbar, [1,I])) # optional - sage.symbolic | |||
| sage: c._contains(vector(QQbar, [1,I])) # optional - sage.rings.number_field | |||
| False | |||
There was a problem hiding this comment.
You are right, thanks.
|
Thanks for reviewing! |
|
Documentation preview for this PR (built with commit 2be9942) is ready! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Update
# optional, PEP 8 fixes for doctests, reformat/align# optional.Taken from (and tested with) current #35095
Part of:
📝 Checklist
⌛ Dependencies