Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maxima from the OS #35615

Closed
wants to merge 11 commits into from
Closed

Maxima from the OS #35615

wants to merge 11 commits into from

Commits on May 3, 2023

  1. fix the linter once more

    fchapoton authored and dimpase committed May 3, 2023
    Configuration menu
    Copy the full SHA
    f6f4e40 View commit details
    Browse the repository at this point in the history
  2. fix the linter once more (sagemath#35552)

    <!-- Please provide a concise, informative and self-explanatory title.
    -->
    <!-- Don't put issue numbers in the title. Put it in the Description
    below. -->
    <!-- For example, instead of "Fixes sagemath#12345", use "Add a new method to
    multiply two integers" -->
    
    ### 📚 Description
    
    Fixing the linter workflow
    
    <!-- Describe your changes here in detail. -->
    <!-- Why is this change required? What problem does it solve? -->
    <!-- If this PR resolves an open issue, please link to it here. For
    example "Fixes sagemath#12345". -->
    <!-- If your change requires a documentation PR, please link it
    appropriately. -->
    
    ### 📝 Checklist
    
    <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x
    ]`. -->
    
    - [x] The title is concise, informative, and self-explanatory.
    - [x] The description explains in detail what this PR is about.
    - [ ] I have linked a relevant issue or discussion.
    - [ ] I have created tests covering the changes.
    - [ ] I have updated the documentation accordingly.
    
    ### ⌛ Dependencies
    
    <!-- List all open PRs that this PR logically depends on
    - sagemath#12345: short description why this is a dependency
    - sagemath#34567: ...
    -->
    
    <!-- If you're unsure about any of these, don't hesitate to ask. We're
    here to help! -->
    dimpase authored May 3, 2023
    Configuration menu
    Copy the full SHA
    4140517 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. Trac sagemath#32867: don't export MAXIMA_PREFIX.

    This should work automatically, and the previous behavior is
    incorrect if we intend to use the system copy of maxima.
    orlitzky authored and dimpase committed May 5, 2023
    Configuration menu
    Copy the full SHA
    892cbe2 View commit details
    Browse the repository at this point in the history
  2. Trac sagemath#32867: new spkg-configure.m4 for maxima.

    This new spkg-configure.m4 checks for both a "maxima" executable, and
    the usability of a "maxima" package by ECL. (The latter requires a
    patched maxima until a new release with commit a0d7a43e523 is made.)
    Notably absent for the moment is a version check, but that should be
    okay: at the moment, the only system copies of maxima that support
    being used as an ECL library are those that are patched, and the only
    reason to patch them is if you intend to use them with SageMath. So in
    short, if a distro patches their maxima to use it with sage, we expect
    it to work with sage.
    
    This commit also moves the SAGE_MAXIMA_FAS variable handling from
    ECL's spkg-configure.m4 to maxima's (where it would have belonged in
    the first place, if maxima had an spkg-configure.m4 at the time.)
    orlitzky authored and dimpase committed May 5, 2023
    Configuration menu
    Copy the full SHA
    1cfec18 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4d5c3b2 View commit details
    Browse the repository at this point in the history
  4. Trac sagemath#32867: disable maxima tests that require matrixexp.patch.

    This patch won't be present in a system copy of maxima (at least for
    now), so we disable these tests to avoid spurious failures once we
    start accepting maxima from the system.
    orlitzky authored and dimpase committed May 5, 2023
    Configuration menu
    Copy the full SHA
    25fbf6c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2b20033 View commit details
    Browse the repository at this point in the history
  6. Trac sagemath#32867: don't set a heap limit for the pexpect maxima.

    We have some old code and an old test for a memory limit that was
    present in ECL 12 years ago, worked around in ticket 6772. The memory
    limit is no longer in place, and would not have applied to a non-ECL
    maxima from the system anyway. Since the test itself is purposely
    wasteful (to ensure that we can use lots of RAM), we take this
    opportunity to remove it and speed up the test suite a bit.
    orlitzky authored and dimpase committed May 5, 2023
    Configuration menu
    Copy the full SHA
    32b64c1 View commit details
    Browse the repository at this point in the history
  7. Trac sagemath#32867: don't require pexpect maxima to live in a "/bin"…

    … directory.
    
    This just fixes a test. The problem was noticed on Arch where, due to
    some other circumstances, maxima was executed from within /usr/sbin.
    But all we know for sure is that maxima will live in PATH. So we
    modify the test to look only for "maxima", and not its parent
    directory.
    orlitzky authored and dimpase committed May 5, 2023
    Configuration menu
    Copy the full SHA
    7a30f8f View commit details
    Browse the repository at this point in the history
  8. Trac sagemath#32867: update package information in distros/arch.txt.

    The ECL library is now contained in a separate maxima-fas package that
    will pull in maxima itself.
    orlitzky authored and dimpase committed May 5, 2023
    Configuration menu
    Copy the full SHA
    3b65c55 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2023

  1. Configuration menu
    Copy the full SHA
    ed729a9 View commit details
    Browse the repository at this point in the history