Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the exceptional Jordan algebra #35629

Merged
merged 3 commits into from
Jun 21, 2023

Conversation

tscrim
Copy link
Collaborator

@tscrim tscrim commented May 9, 2023

📚 Description

"The" exceptional Jordan algebra is a 27 dimensional algebra defined as the $3 \times 3$ self-adjoint matrices over the octonions. This is an important Jordan algebra as it is used to construct the simple Lie group/algebra of type $F_4$.

Fixes #32940.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@tscrim tscrim changed the title Implement the octonions Implement the exceptional Jordan algebra May 9, 2023
@tscrim tscrim added this to the sage-10.1 milestone May 9, 2023
@tscrim tscrim force-pushed the algebras/exceptional_jordan branch 3 times, most recently from ce3d6e8 to 05fd5df Compare May 15, 2023 09:33
@tscrim tscrim force-pushed the algebras/exceptional_jordan branch from 05fd5df to bfad122 Compare May 24, 2023 00:33
@fchapoton
Copy link
Contributor

  • missing the word "matrix" in the sentence self-adjoint 3x3 over an octonion

  • do we have a category and a testsuite that checks the Jordan axioms ?

@tscrim tscrim force-pushed the algebras/exceptional_jordan branch from 1981657 to eb6a706 Compare June 7, 2023 08:15
@tscrim
Copy link
Collaborator Author

tscrim commented Jun 7, 2023

  • missing the word "matrix" in the sentence self-adjoint 3x3 over an octonion

Fixed.

  • do we have a category and a testsuite that checks the Jordan axioms ?

There is no category as I feel the implementations are not complicated enough to warrant one (i.e., an ABC is sufficient). However, there was no _test_jordan_relations() method; I have added it. Good idea!

@fchapoton
Copy link
Contributor

Thanks. The linter is slightly unhappy about too many blank lines.

@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Documentation preview for this PR (built with commit 4772d05) is ready! 🎉

@tscrim
Copy link
Collaborator Author

tscrim commented Jun 10, 2023

The linter is now happy (to the extent it can be).

Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks. Let's move on

@tscrim
Copy link
Collaborator Author

tscrim commented Jun 13, 2023

Thank you!

@vbraun vbraun merged commit b0af318 into sagemath:develop Jun 21, 2023
@tscrim tscrim deleted the algebras/exceptional_jordan branch July 5, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement octonions and split octonions
4 participants