Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify some all(all(...)) in combinat and geometry #35631

Merged
merged 1 commit into from
May 28, 2023

Conversation

fchapoton
Copy link
Contributor

📚 Description

replace some nested all by just one all in combinat and geometry folders

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions
Copy link

github-actions bot commented May 9, 2023

Documentation preview for this PR is ready! 🎉
Built with commit: 0618a28

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented May 11, 2023

There are other changes that are not mentioned in the PR description. Are these from a dependency or also done here? If here, some justification is need for changing a # long time to a # not tested. (I also dislike adding spaces in operators enclosed within a [] operator as I think it makes it harder to read; PEP8 allows no spacing.)

@vbraun vbraun merged commit 43c7f50 into sagemath:develop May 28, 2023
@mkoeppe mkoeppe added this to the sage-10.1 milestone May 28, 2023
@fchapoton fchapoton deleted the simplify_all_all branch July 16, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants