Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some pep8 in elliptic curves #35677

Merged
merged 3 commits into from
Jun 3, 2023
Merged

Some pep8 in elliptic curves #35677

merged 3 commits into from
Jun 3, 2023

Conversation

fchapoton
Copy link
Contributor

📚 Description

Fixing a few pep8 warnings (E222, E203, etc) in schemes/ellipticcurves

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

tscrim
tscrim requested changes May 24, 2023
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM except for the % in many places it just has a space to the left side but it is missing the space from the right side.

@github-actions
Copy link

Documentation preview for this PR (built with commit cab8cb1) is ready! 🎉

@fchapoton
Copy link
Contributor Author

Thanks, this is fixed now.

tscrim
tscrim approved these changes May 26, 2023
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM.

@vbraun vbraun merged commit eca1c9e into sagemath:develop Jun 3, 2023
@mkoeppe mkoeppe added this to the sage-10.1 milestone Jun 3, 2023
@fchapoton fchapoton deleted the some_pep8_in_elliptic_curves branch July 16, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

Assignees
No one assigned
Labels
c: elliptic curves
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.
4 participants
@fchapoton @tscrim @vbraun @mkoeppe