sage.functions: Decouple from sage.symbolic.expression and mpmath, update # needs
#35716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoeppe
force-pushed
the
sage_symbolic_modularization_fixes
branch
from
9aadb6f
to
2eb00e8
Compare
added 20 commits
July 14, 2023 16:11
…be all src/sage/symbolic; ./sage -fixdoctests --only-tags src/sage/symbolic
…c/sage/functions/
…probe all src/sage/functions/
…only-tags src/sage/symbolic/function.pyx
…be all src/sage/symbolic; ./sage -fixdoctests --only-tags src/sage/symbolic
SageMath version 10.1.beta7, Release Date: 2023-07-20
mkoeppe
force-pushed
the
sage_symbolic_modularization_fixes
branch
from
fd2a257
to
370fce7
Compare
added 3 commits
July 30, 2023 12:41
SageMath version 10.1.beta8, Release Date: 2023-07-30
mkoeppe
changed the title
sage.functions: Decouple from sage.symbolic.expression and mpmathsage.functions: Decouple from sage.symbolic.expression and mpmath, update # needs
added 13 commits
August 20, 2023 14:47
mkoeppe
force-pushed
the
sage_symbolic_modularization_fixes
branch
from
794a1eb
to
00e1156
Compare
added 5 commits
August 20, 2023 16:52
…er include_lazy_imports
…ocstring cosmetics
kwankyu
reviewed
Aug 21, 2023
kwankyu
approved these changes
Aug 21, 2023
|
Thank you! |
|
Documentation preview for this PR (built with commit da930eb; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 23, 2023
…ession` and `mpmath`, update `# needs`
<!-- Please provide a concise, informative and self-explanatory title.
-->
<!-- Don't put issue numbers in the title. Put it in the Description
below. -->
<!-- For example, instead of "Fixes sagemath#12345", use "Add a new method to
multiply two integers" -->
### 📚 Description
`sage.functions` advertises itself as providing symbolic functions, but
it also provides the mechanism that dispatches `sin(1.0)` to field
methods such as `RealNumber.sin`, `RealBall.sin` etc.
Here we make the modules from `sage.functions` at least *importable*
when the symbolic subsystem (pynac) is not available. (Evaluating the
functions still goes through the symbolic subsystem as of this PR.) This
is achieved by using `lazy_import` and by moving the symbol table from
`sage.symbolic.expression` (containing pynac) to a new pure Python
module `sage.symbolic.symbols`.
We also use `lazy_import` for imports from `mpmath` and mutual imports
from other modules in `sage.functions`.
A `lazy_import` of `RR` added here reveals a weakness of
`sage.misc.dev_tools.find_objects_from_name` regarding `lazy_import`s
(because `RR` happens to be used in an example for this function.) We
fix it here.
<!-- Describe your changes here in detail. -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
- Part of: sagemath#29705
- Cherry-picked from: sagemath#35095
<!-- If your change requires a documentation PR, please link it
appropriately. -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x
]`. -->
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#35716
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
sage.functionsadvertises itself as providing symbolic functions, but it also provides the mechanism that dispatchessin(1.0)to field methods such asRealNumber.sin,RealBall.sinetc.Here we make the modules from
sage.functionsat least importable when the symbolic subsystem (pynac) is not available. (Evaluating the functions still goes through the symbolic subsystem as of this PR.) This is achieved by usinglazy_importand by moving the symbol table fromsage.symbolic.expression(containing pynac) to a new pure Python modulesage.symbolic.symbols.We also use
lazy_importfor imports frommpmathand mutual imports from other modules insage.functions.A
lazy_importofRRadded here reveals a weakness ofsage.misc.dev_tools.find_objects_from_nameregardinglazy_imports (becauseRRhappens to be used in an example for this function.) We fix it here.📝 Checklist
⌛ Dependencies