Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing a generic one method for unital algebras #36095

Merged
merged 5 commits into from
Sep 1, 2023
Merged

Implementing a generic one method for unital algebras #36095

merged 5 commits into from
Sep 1, 2023

Conversation

tscrim
Copy link
Collaborator

@tscrim tscrim commented Aug 17, 2023

We implement a generic one() method for unital algebras in order to fix the following:

sage: S2 = simplicial_complexes.Sphere(2)
sage: H = S2.cohomology_ring(QQ)
sage: C = cartesian_product([H, H])
sage: C.one()  # this raises an error currently
B[(0, (0, 0))] + B[(1, (0, 0))]

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@fchapoton
Copy link
Contributor

failing doctests

@tscrim tscrim force-pushed the categories/cartesian_product_algebras_one branch from d469d21 to be1d7c3 Compare August 19, 2023 05:58
@tscrim
Copy link
Collaborator Author

tscrim commented Aug 19, 2023

This should fix the errors.

fchapoton
fchapoton approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, arigato, merci

@tscrim
Copy link
Collaborator Author

tscrim commented Aug 21, 2023

@fchapoton merci!

@vbraun
Copy link
Member

vbraun commented Aug 23, 2023

conflict

@tscrim
Copy link
Collaborator Author

tscrim commented Aug 28, 2023

Trivial conflict.

@github-actions
Copy link

Documentation preview for this PR (built with commit 82d7e9d; changes) is ready! 🎉

@vbraun vbraun merged commit f4b2fe9 into sagemath:develop Sep 1, 2023
8 of 11 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Sep 1, 2023
@tscrim tscrim deleted the categories/cartesian_product_algebras_one branch September 12, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchapoton fchapoton fchapoton approved these changes

@nthiery nthiery Awaiting requested review from nthiery

Assignees
No one assigned
Labels
c: algebra c: categories p: major / 3 t: bug t: enhancement
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.
5 participants
@tscrim @fchapoton @vbraun @kwankyu @mkoeppe