Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage.schemes: Update # needs #36102

Merged
merged 295 commits into from
Sep 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
295 commits
Select commit Hold shift + click to select a range
299fc2d
Merge branch 'u/enriqueartal/sirocco_improvements__discriminant_and_o…
enriqueartal Sep 2, 2022
0d0fc48
Starting Puiseux ...
enriqueartal Sep 2, 2022
50b5713
Some improvements including fast comparing algebraic numbers
enriqueartal Sep 2, 2022
5de0b06
cleaning
enriqueartal Sep 2, 2022
a6282e5
going back to compare algebraic numbers
enriqueartal Sep 2, 2022
3e8531e
going back to compare algebraic numbers
enriqueartal Sep 2, 2022
764d1d2
going back to compare algebraic numbers
enriqueartal Sep 2, 2022
c38214b
branch puiseux
enriqueartal Sep 2, 2022
709ca9a
typos for test
enriqueartal Sep 2, 2022
3ca1c98
tests
enriqueartal Sep 2, 2022
f489573
improving relationship of strands and components
enriqueartal Sep 3, 2022
2767a22
improving relationship of strands and components
enriqueartal Sep 3, 2022
89e80ee
lint corrections
enriqueartal Sep 3, 2022
598ce7f
lint corrections
enriqueartal Sep 3, 2022
73a555b
adding optional arguments
enriqueartal Sep 4, 2022
bd51861
adding optional arguments
enriqueartal Sep 4, 2022
e9b313a
bad merge
enriqueartal Sep 4, 2022
052a2c2
Add more functions and methods
enriqueartal Sep 5, 2022
3ab76f9
discrim was too long
enriqueartal Sep 6, 2022
7b05103
discrim was too long
enriqueartal Sep 6, 2022
fede822
fusion
enriqueartal Sep 6, 2022
889daf9
delete some print
enriqueartal Sep 6, 2022
96ad5e9
Merge branch 'u/enriqueartal/sirocco_improvements__discriminant_and_o…
enriqueartal Sep 6, 2022
27cba50
Merge branch 'u/enriqueartal/sirocco_improvements__discriminant_and_o…
enriqueartal Sep 7, 2022
81131ce
Merge branch 'develop' into t/34415/sirocco_improvements__discriminan…
enriqueartal Sep 8, 2022
c4dbcd9
Merge branch 'develop' of https://github.com/sagemath/sage into develop
enriqueartal Sep 8, 2022
f1ccc2e
Merge branch 'develop' into t/34415/sirocco_improvements__discriminan…
enriqueartal Sep 8, 2022
c0ed857
Changes using more algebraic numbers; some tests do not hold
enriqueartal Sep 13, 2022
47a7865
Merge branch 'develop' into t/34415/sirocco_improvements__discriminan…
enriqueartal Sep 17, 2022
7cbaf0f
modification of functions
enriqueartal Sep 17, 2022
d0101b8
Merge branch 'develop' of https://github.com/sagemath/sage into develop
enriqueartal Sep 17, 2022
e40729f
Merge branch 'develop' into t/34415/sirocco_improvements__discriminan…
enriqueartal Sep 17, 2022
7a2556b
Test passed. Check trac 26503
enriqueartal Sep 24, 2022
bcb4797
tests
enriqueartal Sep 24, 2022
bc05632
tests OK
enriqueartal Sep 24, 2022
a4f3916
Merge branch 'develop' into t/34415/sirocco_improvements__discriminan…
enriqueartal Sep 26, 2022
f974a5d
Merge branch 'develop' of https://github.com/sagemath/sage into develop
enriqueartal Sep 26, 2022
e61bae5
Merge branch 'develop' into t/34415/sirocco_improvements__discriminan…
enriqueartal Sep 26, 2022
704e58d
Merge branch 'develop' into t/34415/sirocco_improvements__discriminan…
enriqueartal Sep 30, 2022
ccca460
Merge branch 'develop' of https://github.com/sagemath/sage into develop
enriqueartal Sep 30, 2022
b38e0d0
Merge branch 'develop' into t/34415/sirocco_improvements__discriminan…
enriqueartal Sep 30, 2022
770384e
Geometric basis and oriented circuits
enriqueartal Oct 1, 2022
3cbb828
corrected functions
enriqueartal Oct 2, 2022
0016eff
corrected functions
enriqueartal Oct 2, 2022
092f4f3
add optional to a test
enriqueartal Oct 3, 2022
6ab277c
for lint
enriqueartal Oct 3, 2022
cafff62
step 2 for geometric_basis
enriqueartal Oct 6, 2022
72b7e50
adding dual_graph in gb
enriqueartal Oct 7, 2022
0064af5
1st end of geometric_basis changes
enriqueartal Oct 7, 2022
82ad6b6
1st end of geometric_basis changes
enriqueartal Oct 7, 2022
20a1947
format corrections
enriqueartal Oct 7, 2022
b90c5d7
ultimos cambios
enriqueartal Oct 17, 2022
db92f58
Merge branch 'develop' into puiseux
enriqueartal Oct 17, 2022
09eebcf
Merge branch 'develop' of https://github.com/sagemath/sage into develop
enriqueartal Oct 17, 2022
9a95629
Merge branch 'develop' into puiseux
enriqueartal Oct 17, 2022
9426ef1
Merge branch 'develop' into puiseux
enriqueartal Oct 31, 2022
523ff7a
Merge branch 'develop' of https://github.com/sagemath/sage into develop
enriqueartal Oct 31, 2022
8aa0cf3
Merge branch 'develop' into puiseux
enriqueartal Oct 31, 2022
2750d1e
Merge branch 'develop' into puiseux
enriqueartal Nov 22, 2022
0c6b385
Merge branch 'develop' of https://github.com/sagemath/sage into develop
enriqueartal Nov 22, 2022
db4007f
Merge branch 'develop' into puiseux
enriqueartal Nov 22, 2022
bc2075e
Merge branch 'develop' into puiseux
enriqueartal Dec 11, 2022
7e08d9d
Merge branch 'develop' of https://github.com/sagemath/sage into develop
enriqueartal Dec 11, 2022
edc1ce3
Merge branch 'develop' into puiseux
enriqueartal Dec 11, 2022
acd112b
Merge branch 'develop' into puiseux
enriqueartal Dec 22, 2022
1a7b6c1
Merge branch 'develop' of https://github.com/sagemath/sage into develop
enriqueartal Dec 22, 2022
32fc448
Merge branch 'develop' into puiseux
enriqueartal Dec 22, 2022
9cebfc7
Merge branch 'develop' into puiseux
enriqueartal Jan 19, 2023
abbe02f
Merge branch 'develop' of https://github.com/sagemath/sage into develop
enriqueartal Jan 19, 2023
ed5f6d7
Merge branch 'develop' into puiseux
enriqueartal Jan 19, 2023
0340f15
Merge branch 'develop' of https://github.com/sagemath/sage into develop
enriqueartal Jan 30, 2023
a18c715
Merge branch 'develop' into puiseux
enriqueartal Jan 30, 2023
6e138a5
Merge branch 'develop' into puiseux
enriqueartal Jan 30, 2023
95c64f5
Merge branch 'develop' into puiseux
enriqueartal Feb 6, 2023
6702f91
Merge branch 'develop' of https://github.com/sagemath/sage into develop
enriqueartal Feb 6, 2023
9316ccc
Merge branch 'develop' into puiseux
enriqueartal Feb 6, 2023
7ff5041
Merge branch 'develop' into puiseux
enriqueartal Feb 11, 2023
eae5c7e
Merge branch 'develop' of https://github.com/sagemath/sage into develop
enriqueartal Feb 11, 2023
a13d463
Merge branch 'develop' into puiseux
enriqueartal Feb 11, 2023
ec37079
Merge branch 'develop' into puiseux
enriqueartal Feb 14, 2023
f7a1281
Merge branch 'develop' of https://github.com/sagemath/sage into develop
enriqueartal Feb 14, 2023
caa61a4
Merge branch 'develop' into puiseux
enriqueartal Feb 14, 2023
2abee3d
correciones zvk
enriqueartal Feb 15, 2023
ffb37e4
Merge branch 'develop' of https://github.com/sagemath/sage into develop
enriqueartal Feb 15, 2023
9cc8d12
Merge branch 'develop' into puiseux
enriqueartal Feb 15, 2023
fde3daf
typos
enriqueartal Feb 15, 2023
7b3b14d
Merge branch 'puiseux' of github.com:enriqueartal/sage into puiseux
enriqueartal Feb 15, 2023
c4641dc
avoid repetitions
enriqueartal Feb 15, 2023
050d8bc
style
enriqueartal Feb 15, 2023
8c36342
changes in base fields caused errors in tests
enriqueartal Feb 15, 2023
47f036a
too optional lines
enriqueartal Feb 15, 2023
5f54caa
more optional issues for testing
enriqueartal Feb 16, 2023
33359bf
Merge branch 'develop' into puiseux
enriqueartal Feb 20, 2023
1817187
Merge branch 'sagemath:develop' into puiseux
enriqueartal Feb 20, 2023
1755c31
Merge branch 'develop' into puiseux
enriqueartal Feb 24, 2023
3e1b429
Merge branch 'puiseux' of github.com:enriqueartal/sage into puiseux
enriqueartal Feb 24, 2023
d32000e
small corrections
enriqueartal Feb 27, 2023
4423a94
Merge branch 'sagemath:develop' into puiseux
enriqueartal Mar 3, 2023
e3d961b
Merge branch 'sagemath:develop' into puiseux
enriqueartal Mar 13, 2023
1ee08de
error doc
enriqueartal Mar 18, 2023
cf22a28
Mejorar documentacion
enriqueartal Mar 18, 2023
c7feda2
checking geometric_basis
enriqueartal Mar 18, 2023
11ee3d4
adding examples
enriqueartal Mar 18, 2023
56d8ec6
doc typos
enriqueartal Mar 18, 2023
b650801
doc typos
enriqueartal Mar 18, 2023
beab5ca
forgot optional sirocco
enriqueartal Mar 18, 2023
439b663
new aux function voronoi_cells to simplify braid_monodromy
enriqueartal Mar 19, 2023
7a07c08
more examples affine curve
enriqueartal Mar 19, 2023
7ee7f66
.
enriqueartal Mar 19, 2023
a763faf
doc
enriqueartal Mar 19, 2023
36515b3
Merge branch 'sagemath:develop' into puiseux
enriqueartal Mar 19, 2023
2f74039
fundamental_group_arrangement
enriqueartal Mar 20, 2023
8b89c42
examples for fundamental_group_arrangement
enriqueartal Mar 20, 2023
08ab579
adding optional sirocco to some examples
enriqueartal Mar 20, 2023
587afdb
style
enriqueartal Mar 21, 2023
4388485
Merge branch 'sagemath:develop' into puiseux
enriqueartal Mar 26, 2023
270ef0a
avoid import from all.py
enriqueartal Mar 26, 2023
a4813d4
fix braid2rels
enriqueartal Mar 27, 2023
3ca7ac2
Add TODO
enriqueartal Mar 28, 2023
468d7c7
remove empty line
enriqueartal Mar 28, 2023
f1a9dd3
imports are now alphabetically ordered
enriqueartal Mar 31, 2023
9adb255
Merge branch 'sagemath:develop' into puiseux
enriqueartal Apr 1, 2023
2350007
delete spaces after keywords
enriqueartal Apr 5, 2023
27faf9e
solve merge conflicts
enriqueartal Apr 7, 2023
332a878
remove some indents
enriqueartal Apr 8, 2023
513fb29
build/pkgs/libgd/spkg-src: Obsolete, remove
mkoeppe Apr 10, 2023
b2c4fc8
build/pkgs/libgd: Disable most libraries, remove dependencies
mkoeppe Apr 10, 2023
24543e4
build/pkgs/libgd: Upgrade to 2.3.3
mkoeppe Apr 10, 2023
403ce40
Merge branch 'sagemath:develop' into puiseux
enriqueartal Apr 14, 2023
5b4f447
Add trivial cases and method for line arrangements
enriqueartal Apr 15, 2023
41ab326
typos
enriqueartal Apr 15, 2023
d14da65
fundamental group of projective line arrangements
enriqueartal Apr 16, 2023
9ab56cc
dimension 1
enriqueartal Apr 16, 2023
90a7d72
hyperplane sections
enriqueartal Apr 16, 2023
387f423
Consider permutations
enriqueartal Apr 16, 2023
c8c1714
correct permutation to restriction
enriqueartal Apr 17, 2023
004df52
fundamental group
enriqueartal Apr 17, 2023
cbae394
lint error
enriqueartal Apr 17, 2023
54ee1d7
permutation in essentialization
enriqueartal Apr 17, 2023
e1a8c72
problems in permutation for hyperplane_section
enriqueartal Apr 18, 2023
4f19314
solved hyperplane_section
enriqueartal Apr 18, 2023
c2e13f4
Merge branch 'sagemath:develop' into puiseux
enriqueartal Apr 23, 2023
ce6d2dc
Merge pull request #1 from mkoeppe/gcc_13
enriqueartal Apr 24, 2023
92baa65
Merge pull request #2 from mkoeppe/libgd_reduce_deps
enriqueartal Apr 24, 2023
bfd7180
allow gfortran 13
enriqueartal Apr 24, 2023
f080534
More permutations for hyperplane arrangements
enriqueartal Apr 25, 2023
85ee2dc
Merge branch 'sagemath:develop' into puiseux
enriqueartal Apr 29, 2023
bbf00de
add optionals
enriqueartal Apr 30, 2023
cf50efb
Merge branch 'sagemath:develop' into puiseux
enriqueartal May 7, 2023
e8e1cd8
Merge branch 'sagemath:develop' into puiseux
enriqueartal May 12, 2023
fcdd37a
Merge branch 'sagemath:develop' into puiseux
enriqueartal May 21, 2023
08125ec
make faster the computation of Puiseux relations
enriqueartal May 22, 2023
79a8ac5
Move parallel functions to appear in doc
enriqueartal May 23, 2023
b3d6b05
merge 10.1beta0
enriqueartal May 23, 2023
e570851
vertical braid monodromy
enriqueartal May 25, 2023
9039d89
Merge changes of examples in arrangement.py
enriqueartal May 29, 2023
47a8732
correcting geometric basis
enriqueartal May 30, 2023
7d9dda8
lint changes
enriqueartal May 30, 2023
e551674
more lint changes
enriqueartal May 30, 2023
d84c3c0
update z_vk
enriqueartal May 31, 2023
e2b1adc
Merge branch 'puiseux' of github.com:enriqueartal/sage into puiseux
enriqueartal May 31, 2023
12e1cce
some cases for geometrical basis
enriqueartal May 31, 2023
c18b551
Merge branch 'puiseux' of github.com:enriqueartal/sage into puiseux
enriqueartal May 31, 2023
4ab061e
cleaning
enriqueartal May 31, 2023
49ad1ad
Merge branch 'sagemath:develop' into puiseux
enriqueartal Jun 4, 2023
817fcf7
Merge branch 'puiseux' of github.com:enriqueartal/sage into puiseux
enriqueartal Jun 4, 2023
4a18673
mistake in geometric_basis
enriqueartal Jun 9, 2023
0ba8367
Merge branch 'puiseux' of github.com:enriqueartal/sage into puiseux
enriqueartal Jun 9, 2023
0a2269d
Merge branch 'sagemath:develop' into puiseux
enriqueartal Jun 11, 2023
eb3761e
Merge branch 'sagemath:develop' into puiseux
enriqueartal Jun 22, 2023
69ff829
cleaning up
enriqueartal Jun 27, 2023
384283c
cleaning voronoi_cells and orient_circuit
enriqueartal Jun 27, 2023
af31802
lsp changes
enriqueartal Jun 28, 2023
d5502c1
simplify roots_interval
enriqueartal Jun 28, 2023
77bb150
small corrections
enriqueartal Jun 28, 2023
bc829c6
Merge branch 'sagemath:develop' into puiseux
enriqueartal Jul 2, 2023
c5ee76b
Merge branch 'sagemath:develop' into puiseux
enriqueartal Jul 9, 2023
fd8aa9c
braid_monodromy
enriqueartal Jul 18, 2023
7539b55
correction after changing braid_monodromy
enriqueartal Jul 18, 2023
68287f4
pre-final corrections zvk
enriqueartal Jul 19, 2023
3ff1436
till fundamental group from bm
enriqueartal Jul 19, 2023
59754f3
src/sage/schemes/curves/affine_curve.py
enriqueartal Jul 19, 2023
3cf4c4c
fundamental group changes
enriqueartal Jul 19, 2023
29b8787
typos in doc of conjugate_positive_form
enriqueartal Jul 19, 2023
53cee22
prefinal
enriqueartal Jul 20, 2023
9e3c1ca
arreglar diccionarios
enriqueartal Jul 20, 2023
8dc33f7
back to original hyperplane, changes to a new branch
enriqueartal Jul 20, 2023
26fc7d7
typo in docs
enriqueartal Jul 21, 2023
26b4aab
merge
enriqueartal Jul 21, 2023
4b48dce
merge and discard change in develop
enriqueartal Jul 31, 2023
d9568b1
avoid warnings in test for zariski_vankampen
enriqueartal Aug 2, 2023
4e56f40
Merge branch 'sagemath:develop' into puiseux
enriqueartal Aug 7, 2023
c91fdbe
Merge branch 'sagemath:develop' into puiseux
enriqueartal Aug 13, 2023
9edfab6
introduce changes from #36092
enriqueartal Aug 15, 2023
df02347
sage.schemes: ./sage -fixdoctests --long --distribution 'sagemath-mod…
mkoeppe Jun 28, 2023
129f7c1
./sage -fixdoctests --only-tags src/sage/schemes/projective/projectiv…
mkoeppe Jun 30, 2023
9794b71
sage.schemes: Update # needs
mkoeppe Jun 30, 2023
465ac19
src/sage/schemes/product_projective/space.py: Update # needs
mkoeppe Jun 30, 2023
63eef51
Update # optional/needs
mkoeppe Jul 1, 2023
fcf3f7c
More optional / # needs
mkoeppe Jul 1, 2023
a401363
sage.schemes: Update # optional / # needs
mkoeppe Jul 2, 2023
029dc4d
sage.{modular,schemes}: Add # needs
mkoeppe Jul 3, 2023
f5a7cbe
sage.schemes: Update # needs
mkoeppe Jul 3, 2023
aeb3ced
sage.schemes: Update # needs
mkoeppe Jul 3, 2023
6fd0048
src/sage/rings/polynomial/polynomial_ring.py: Use '# needs sage.libs.…
mkoeppe Jul 8, 2023
8559999
./sage -fixdoctests --distribution sagemath-categories --probe all --…
mkoeppe Jul 13, 2023
1df8e8c
sage.schemes: Update # needs
mkoeppe Jul 14, 2023
a5da282
More # needs
mkoeppe Jul 22, 2023
1a59407
sage.schemes: Update # needs
mkoeppe Aug 2, 2023
17324b1
sage.schemes: Update # needs
mkoeppe Aug 7, 2023
b6224fa
src/sage/schemes: Update file-level doctest tag
mkoeppe Aug 7, 2023
1a463ed
src/sage/schemes: sage -fixdoctests --only-tags
mkoeppe Aug 8, 2023
152a7bd
sage --fixdoctests --no-test
mkoeppe Aug 13, 2023
fef539e
sage.schemes: Use more block tags
mkoeppe Aug 18, 2023
f4b2a48
sage.schemes: Remove many unnecessary # needs - sage.rings.finite_rin…
mkoeppe Aug 18, 2023
b0f148e
sage.schemes: More block tags
mkoeppe Aug 18, 2023
000dfc1
src/sage/schemes/projective/projective_rational_point.py
mkoeppe Aug 19, 2023
8fef9dc
sage.schemes: More block tags, remove many unnecessary # needs - sage…
mkoeppe Aug 19, 2023
b84bfec
sage.schemes: Even more block tags, remove many unnecessary # needs -…
mkoeppe Aug 19, 2023
0b4207e
sage.schemes: Yet more block tags, remove many unnecessary # needs - …
mkoeppe Aug 19, 2023
7b665f3
sage -fixdoctests --long --fixed-point --only-tags --overwrite src/sa…
mkoeppe Aug 21, 2023
12ee3a4
src/sage/schemes/berkovich/berkovich_cp_element.py: Remove empty 'sag…
mkoeppe Aug 22, 2023
8151bb3
src/sage/schemes/berkovich/berkovich_space.py: Remove empty 'sage:' l…
mkoeppe Aug 22, 2023
23f123e
src/sage/schemes/berkovich/berkovich_space.py: Doctest formatting fixups
mkoeppe Aug 22, 2023
e6f9b08
src/sage/schemes/curves/affine_curve.py: Remove wrong tag
mkoeppe Aug 22, 2023
9d5dfa7
src/sage/schemes/plane_conics/con_field.py: Restore lost issue refere…
mkoeppe Aug 22, 2023
278e3be
src/sage/schemes/plane_conics/con_field.py: Restore lost '# random'
mkoeppe Aug 22, 2023
4eaca5d
src/sage/schemes/projective/projective_morphism.py: Use more block tags
mkoeppe Aug 22, 2023
79e2478
src/sage/schemes/projective/projective_point.py: Use more block tags
mkoeppe Aug 22, 2023
ae015d1
changes proposed by miguelmarco
enriqueartal Aug 22, 2023
3ff8247
more changes from review and from #36022
enriqueartal Aug 22, 2023
c7dadc7
some tests
enriqueartal Aug 23, 2023
4e38e31
another test (codecov) for braid_monodromy
enriqueartal Aug 23, 2023
c976414
more tests for codecov
enriqueartal Aug 23, 2023
012c98a
check for random parallel error
enriqueartal Aug 27, 2023
a65c6f8
add optional sirocco
enriqueartal Aug 27, 2023
f3e9b58
add a method to sort presentations and avoid test errors
enriqueartal Aug 27, 2023
15dcdbc
some more sorted_presentation's
enriqueartal Aug 28, 2023
dd6dce5
Merge branch 'sagemath:develop' into puiseux
enriqueartal Aug 28, 2023
47087e7
again more sorted_presentation's
enriqueartal Aug 28, 2023
dba9ea0
add inverse relations for sorting presentations
enriqueartal Aug 28, 2023
89c945b
fixing doctest and get rid of optional warnings
enriqueartal Aug 28, 2023
df7d90d
Merge branch 'puiseux' into needs_for_sage_schemes, doctest cosmetics
mkoeppe Aug 28, 2023
1d89cbf
changes proposed in PR#36102
enriqueartal Aug 29, 2023
699ee2d
Merge branch 'puiseux' into needs_for_sage_schemes
mkoeppe Aug 29, 2023
5f7beec
move an optional sirocco to check doctest
enriqueartal Aug 29, 2023
ba38dc8
write sage: instead of sage in a doctest
enriqueartal Aug 30, 2023
c6807ef
Merge branch 'puiseux' into needs_for_sage_schemes
mkoeppe Aug 30, 2023
fa2c771
remove extra spaces and blank lines reviewed in #36102
enriqueartal Aug 31, 2023
3e2de54
Merge branch 'puiseux' into needs_for_sage_schemes
mkoeppe Aug 31, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/doc/en/reference/curves/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Curves
sage/schemes/curves/projective_curve
sage/schemes/curves/point
sage/schemes/curves/closed_point
sage/schemes/curves/zariski_vankampen

sage/schemes/jacobians/abstract_jacobian

Expand Down
30 changes: 30 additions & 0 deletions src/sage/groups/finitely_presented.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@
from sage.libs.gap.libgap import libgap
from sage.libs.gap.element import GapElement
from sage.misc.cachefunc import cached_method
from sage.groups.free_group import FreeGroup
from sage.groups.free_group import FreeGroupElement
from sage.functions.generalized import sign
from sage.matrix.constructor import matrix
Expand Down Expand Up @@ -1426,6 +1427,35 @@ def simplified(self):
"""
return self.simplification_isomorphism().codomain()

def sorted_presentation(self):
"""
Return the same presentation with the relations sorted to ensure equality.

OUTPUT:

A new finitely presented group with the relations sorted.

EXAMPLES::

sage: G = FreeGroup(2) / [(1, 2, -1, -2), ()]; G
Finitely presented group < x0, x1 | x0*x1*x0^-1*x1^-1, 1 >
sage: G.sorted_presentation()
Finitely presented group < x0, x1 | 1, x1^-1*x0^-1*x1*x0 >
"""
F = FreeGroup(self.ngens())
L0 = [r.Tietze() for r in self.relations()]
L1 = []
for rel in L0:
C = [rel]
for j in range(len(rel) - 1):
C.append(rel[j + 1:] + rel[:j + 1])
C1 = [tuple(-j for j in reversed(l)) for l in C]
C += C1
C.sort()
L1.append(C[0])
L1.sort()
return F/L1

def epimorphisms(self, H):
r"""
Return the epimorphisms from `self` to `H`, up to automorphism of `H`.
Expand Down
9 changes: 5 additions & 4 deletions src/sage/modular/abvar/homspace.py
Original file line number Diff line number Diff line change
Expand Up @@ -148,14 +148,15 @@

::

sage: T = E.image_of_hecke_algebra() # long time
sage: T.gens() # long time
sage: # long time
sage: T = E.image_of_hecke_algebra()
sage: T.gens()
(Abelian variety endomorphism of Abelian variety J0(33) of dimension 3,
Abelian variety endomorphism of Abelian variety J0(33) of dimension 3,
Abelian variety endomorphism of Abelian variety J0(33) of dimension 3)
sage: T.index_in(E) # long time
sage: T.index_in(E)
+Infinity
sage: T.index_in_saturation() # long time
sage: T.index_in_saturation()
1

AUTHORS:
Expand Down
13 changes: 8 additions & 5 deletions src/sage/modular/cusps_nf.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# sage.doctest: needs sage.rings.number_field
r"""
The set `\mathbb{P}^1(K)` of cusps of a number field `K`

Expand Down Expand Up @@ -62,7 +63,7 @@

sage: Gamma0_NFCusps(N)
[Cusp [0: 1] of Number Field in a with defining polynomial x^2 + 5,
Cusp [1: 3] of Number Field in a with defining polynomial x^2 + 5,
Cusp [1: 3] of Number Field in a with defining polynomial x^2 + 5,
...]
"""
# ****************************************************************************
Expand Down Expand Up @@ -859,7 +860,7 @@ def ABmatrix(self):
sage: M = alpha.ABmatrix()
sage: M # random
[-a^2 - a - 1, -3*a - 7, 8, -2*a^2 - 3*a + 4]
sage: M[0] == alpha.numerator() and M[2]==alpha.denominator()
sage: M[0] == alpha.numerator() and M[2] == alpha.denominator()
True

An AB-matrix associated to a cusp alpha will send Infinity to alpha:
Expand All @@ -870,7 +871,7 @@ def ABmatrix(self):
sage: M = alpha.ABmatrix()
sage: (k.ideal(M[1], M[3])*alpha.ideal()).is_principal()
True
sage: M[0] == alpha.numerator() and M[2]==alpha.denominator()
sage: M[0] == alpha.numerator() and M[2] == alpha.denominator()
True
sage: NFCusp(k, oo).apply(M) == alpha
True
Expand Down Expand Up @@ -1249,7 +1250,8 @@ def units_mod_ideal(I):
sage: from sage.modular.cusps_nf import units_mod_ideal
sage: k.<a> = NumberField(x^3 + 11)
sage: k.unit_group()
Unit group with structure C2 x Z of Number Field in a with defining polynomial x^3 + 11
Unit group with structure C2 x Z of
Number Field in a with defining polynomial x^3 + 11
sage: I = k.ideal(5, a + 1)
sage: units_mod_ideal(I)
[1,
Expand All @@ -1261,7 +1263,8 @@ def units_mod_ideal(I):
sage: from sage.modular.cusps_nf import units_mod_ideal
sage: k.<a> = NumberField(x^4 - x^3 -21*x^2 + 17*x + 133)
sage: k.unit_group()
Unit group with structure C6 x Z of Number Field in a with defining polynomial x^4 - x^3 - 21*x^2 + 17*x + 133
Unit group with structure C6 x Z of
Number Field in a with defining polynomial x^4 - x^3 - 21*x^2 + 17*x + 133
sage: I = k.ideal(3)
sage: U = units_mod_ideal(I)
sage: all(U[j].is_unit() and (U[j] not in I) for j in range(len(U)))
Expand Down
11 changes: 6 additions & 5 deletions src/sage/modular/modform/element.py
Original file line number Diff line number Diff line change
Expand Up @@ -2315,13 +2315,14 @@ def minimal_twist(self, p=None):
sage: f.twist(chi, level=11) == g
True

sage: f = Newforms(575, 2, names='a')[4] # long time
sage: g, chi = f.minimal_twist(5) # long time
sage: g # long time
sage: # long time
sage: f = Newforms(575, 2, names='a')[4]
sage: g, chi = f.minimal_twist(5)
sage: g
q + a*q^2 - a*q^3 - 2*q^4 + (1/2*a + 2)*q^5 + O(q^6)
sage: chi # long time
sage: chi
Dirichlet character modulo 5 of conductor 5 mapping 2 |--> 1/2*a
sage: f.twist(chi, level=g.level()) == g # long time
sage: f.twist(chi, level=g.level()) == g
True
"""
if p is None:
Expand Down
1 change: 1 addition & 0 deletions src/sage/modular/modform_hecketriangle/analytic_type.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# sage.doctest: needs sage.graphs
r"""
Analytic types of modular forms

Expand Down
24 changes: 16 additions & 8 deletions src/sage/modular/overconvergent/weightspace.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# -*- coding: utf-8 -*-
# sage.doctest: needs sage.rings.padics
r"""
The space of `p`-adic weights

Expand All @@ -17,7 +17,8 @@

sage: W = pAdicWeightSpace(17)
sage: W
Space of 17-adic weight-characters defined over 17-adic Field with capped relative precision 20
Space of 17-adic weight-characters
defined over 17-adic Field with capped relative precision 20
sage: R.<x> = QQ[]
sage: L = Qp(17).extension(x^2 - 17, names='a'); L.rename('L')
sage: W.base_extend(L)
Expand Down Expand Up @@ -101,7 +102,8 @@ def WeightSpace_constructor(p, base_ring=None):
EXAMPLES::

sage: pAdicWeightSpace(3) # indirect doctest
Space of 3-adic weight-characters defined over 3-adic Field with capped relative precision 20
Space of 3-adic weight-characters
defined over 3-adic Field with capped relative precision 20
sage: pAdicWeightSpace(3, QQ)
Space of 3-adic weight-characters defined over Rational Field
sage: pAdicWeightSpace(10)
Expand Down Expand Up @@ -248,11 +250,13 @@ def base_extend(self, R):

sage: W = pAdicWeightSpace(3, QQ)
sage: W.base_extend(Qp(3))
Space of 3-adic weight-characters defined over 3-adic Field with capped relative precision 20
Space of 3-adic weight-characters
defined over 3-adic Field with capped relative precision 20
sage: W.base_extend(IntegerModRing(12))
Traceback (most recent call last):
...
TypeError: No coercion map from 'Rational Field' to 'Ring of integers modulo 12' is defined
TypeError: No coercion map from 'Rational Field'
to 'Ring of integers modulo 12' is defined
"""
if R.has_coerce_map_from(self.base_ring()):
return WeightSpace_constructor(self.prime(), R)
Expand Down Expand Up @@ -356,7 +360,9 @@ def pAdicEisensteinSeries(self, ring, prec=20):

sage: kappa = pAdicWeightSpace(3)(3, DirichletGroup(3,QQ).0)
sage: kappa.pAdicEisensteinSeries(QQ[['q']], 20)
1 - 9*q + 27*q^2 - 9*q^3 - 117*q^4 + 216*q^5 + 27*q^6 - 450*q^7 + 459*q^8 - 9*q^9 - 648*q^10 + 1080*q^11 - 117*q^12 - 1530*q^13 + 1350*q^14 + 216*q^15 - 1845*q^16 + 2592*q^17 + 27*q^18 - 3258*q^19 + O(q^20)
1 - 9*q + 27*q^2 - 9*q^3 - 117*q^4 + 216*q^5 + 27*q^6 - 450*q^7 + 459*q^8
- 9*q^9 - 648*q^10 + 1080*q^11 - 117*q^12 - 1530*q^13 + 1350*q^14 + 216*q^15
- 1845*q^16 + 2592*q^17 + 27*q^18 - 3258*q^19 + O(q^20)
"""
if not self.is_even():
raise ValueError("Eisenstein series not defined for odd weight-characters")
Expand Down Expand Up @@ -570,7 +576,8 @@ def chi(self):

sage: kappa = pAdicWeightSpace(29)(13, DirichletGroup(29, Qp(29)).0^14)
sage: kappa.chi()
Dirichlet character modulo 29 of conductor 29 mapping 2 |--> 28 + 28*29 + 28*29^2 + ... + O(29^20)
Dirichlet character modulo 29 of conductor 29
mapping 2 |--> 28 + 28*29 + 28*29^2 + ... + O(29^20)
"""
return self._chi

Expand Down Expand Up @@ -667,7 +674,8 @@ def Lvalue(self):
sage: pAdicWeightSpace(7)(5, DirichletGroup(7, Qp(7)).0^4).Lvalue()
0
sage: pAdicWeightSpace(7)(6, DirichletGroup(7, Qp(7)).0^4).Lvalue()
1 + 2*7 + 7^2 + 3*7^3 + 3*7^5 + 4*7^6 + 2*7^7 + 5*7^8 + 2*7^9 + 3*7^10 + 6*7^11 + 2*7^12 + 3*7^13 + 5*7^14 + 6*7^15 + 5*7^16 + 3*7^17 + 6*7^18 + O(7^19)
1 + 2*7 + 7^2 + 3*7^3 + 3*7^5 + 4*7^6 + 2*7^7 + 5*7^8 + 2*7^9 + 3*7^10 + 6*7^11
+ 2*7^12 + 3*7^13 + 5*7^14 + 6*7^15 + 5*7^16 + 3*7^17 + 6*7^18 + O(7^19)
"""
if self._k > 0:
return -self._chi.bernoulli(self._k) / self._k
Expand Down
2 changes: 1 addition & 1 deletion src/sage/modular/pollack_stevens/padic_lseries.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# -*- coding: utf-8 -*-
# sage.doctest: needs sage.ring.padics
r"""
`p`-adic `L`-series attached to overconvergent eigensymbols

Expand Down
39 changes: 20 additions & 19 deletions src/sage/schemes/affine/affine_homset.py
Original file line number Diff line number Diff line change
Expand Up @@ -211,8 +211,8 @@ def points(self, **kwds):
EXAMPLES: The bug reported at #11526 is fixed::

sage: A2 = AffineSpace(ZZ, 2)
sage: F = GF(3) # optional - sage.rings.finite_rings
sage: A2(F).points() # optional - sage.rings.finite_rings
sage: F = GF(3)
sage: A2(F).points()
[(0, 0), (0, 1), (0, 2), (1, 0), (1, 1), (1, 2), (2, 0), (2, 1), (2, 2)]

::
Expand All @@ -228,23 +228,23 @@ def points(self, **kwds):
::

sage: u = QQ['u'].0
sage: K.<v> = NumberField(u^2 + 3) # optional - sage.rings.number_field
sage: A.<x,y> = AffineSpace(K, 2) # optional - sage.rings.number_field
sage: len(A(K).points(bound=2)) # optional - sage.rings.number_field
sage: K.<v> = NumberField(u^2 + 3) # needs sage.rings.number_field
sage: A.<x,y> = AffineSpace(K, 2) # needs sage.rings.number_field
sage: len(A(K).points(bound=2)) # needs sage.rings.number_field
1849

::

sage: A.<x,y> = AffineSpace(QQ, 2)
sage: E = A.subscheme([x^2 + y^2 - 1, y^2 - x^3 + x^2 + x - 1])
sage: E(A.base_ring()).points()
sage: E(A.base_ring()).points() # needs sage.libs.singular
[(-1, 0), (0, -1), (0, 1), (1, 0)]

::

sage: A.<x,y> = AffineSpace(CC, 2)
sage: A.<x,y> = AffineSpace(CC, 2) # needs sage.rings.real_mpfr
sage: E = A.subscheme([y^3 - x^3 - x^2, x*y])
sage: E(A.base_ring()).points()
sage: E(A.base_ring()).points() # needs sage.libs.singular sage.rings.real_mpfr
verbose 0 (...: affine_homset.py, points)
Warning: computations in the numerical fields are inexact;points
may be computed partially or incorrectly.
Expand All @@ -253,9 +253,9 @@ def points(self, **kwds):

::

sage: A.<x1,x2> = AffineSpace(CDF, 2)
sage: E = A.subscheme([x1^2 + x2^2 + x1*x2, x1 + x2])
sage: E(A.base_ring()).points()
sage: A.<x1,x2> = AffineSpace(CDF, 2) # needs sage.rings.complex_double
sage: E = A.subscheme([x1^2 + x2^2 + x1*x2, x1 + x2]) # needs sage.libs.singular sage.rings.complex_double
sage: E(A.base_ring()).points() # needs sage.libs.singular sage.rings.complex_double
verbose 0 (...: affine_homset.py, points)
Warning: computations in the numerical fields are inexact;points
may be computed partially or incorrectly.
Expand Down Expand Up @@ -393,28 +393,29 @@ def numerical_points(self, F=None, **kwds):

EXAMPLES::

sage: K.<v> = QuadraticField(3) # optional - sage.rings.number_field
sage: A.<x,y> = AffineSpace(K, 2) # optional - sage.rings.number_field
sage: X = A.subscheme([x^3 - v^2*y, y - v*x^2 + 3]) # optional - sage.rings.number_field
sage: L = X(K).numerical_points(F=RR); L # abs tol 1e-14 # optional - sage.rings.number_field
sage: # needs sage.rings.number_field
sage: K.<v> = QuadraticField(3)
sage: A.<x,y> = AffineSpace(K, 2)
sage: X = A.subscheme([x^3 - v^2*y, y - v*x^2 + 3])
sage: L = X(K).numerical_points(F=RR); L # abs tol 1e-14
[(-1.18738247880014, -0.558021142104134),
(1.57693558184861, 1.30713548084184),
(4.80659931965815, 37.0162574656220)]
sage: L[0].codomain() # optional - sage.rings.number_field
sage: L[0].codomain()
Affine Space of dimension 2 over Real Field with 53 bits of precision

::

sage: A.<x,y> = AffineSpace(QQ, 2)
sage: X = A.subscheme([y^2 - x^2 - 3*x, x^2 - 10*y])
sage: len(X(QQ).numerical_points(F=ComplexField(100)))
sage: len(X(QQ).numerical_points(F=ComplexField(100))) # needs sage.libs.singular
4

::

sage: A.<x1, x2> = AffineSpace(QQ, 2)
sage: E = A.subscheme([30*x1^100 + 1000*x2^2 + 2000*x1*x2 + 1, x1 + x2])
sage: len(E(A.base_ring()).numerical_points(F=CDF, zero_tolerance=1e-9))
sage: len(E(A.base_ring()).numerical_points(F=CDF, zero_tolerance=1e-9)) # needs sage.libs.singular
100

TESTS::
Expand All @@ -430,7 +431,7 @@ def numerical_points(self, F=None, **kwds):

sage: A.<x,y> = AffineSpace(QQ, 2)
sage: X = A.subscheme([y^2 - x^2 - 3*x, x^2 - 10*y])
sage: X(QQ).numerical_points(F=CC, zero_tolerance=-1)
sage: X(QQ).numerical_points(F=CC, zero_tolerance=-1) # needs sage.libs.singular
Traceback (most recent call last):
...
ValueError: tolerance must be positive
Expand Down
Loading
Loading