src/sage/tests: fix another "Computational Math..." doctest #36185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One doctest for the Computational Math book fails for me,
Failed example:
limit(f(t * cos(theta), t * sin(theta)) / t, t=0)
Expected:
cos(theta)^2/sin(theta)
Got:
-1/2*(sin(3*theta) + sin(theta))/(cos(2*theta) - 1)
These results are equivalent, and the ugly one simplifies to the
pretty one. We add a full_simplify() to the test to support both
outputs. The discrepancy is most likely due to the version of Giac
installed on the system.
|
Documentation preview for this PR (built with commit bcd71cd; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 5, 2023
… doctest
One doctest for the Computational Math book fails for me,
```
Failed example:
limit(f(t * cos(theta), t * sin(theta)) / t, t=0)
Expected:
cos(theta)^2/sin(theta)
Got:
-1/2*(sin(3*theta) + sin(theta))/(cos(2*theta) - 1)
```
These results are equivalent, and the ugly one simplifies to the pretty
one. We add a full_simplify() to the test to support both outputs. The
discrepancy is most likely due to the version of Giac installed on the
system.
URL: sagemath#36185
Reported by: Michael Orlitzky
Reviewer(s): Kwankyu Lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One doctest for the Computational Math book fails for me,
These results are equivalent, and the ugly one simplifies to the pretty one. We add a full_simplify() to the test to support both outputs. The discrepancy is most likely due to the version of Giac installed on the system.