use semi-primitive root when checking kernel polynomials of isogenies #36187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks OK after a quick look I can't test properly for a while but if the tests pass it's fine with me. |
|
Documentation preview for this PR (built with commit c518b47; changes) is ready! 🎉 |
tscrim
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Based on @JohnCremona comment, since it passes tests I am approving this.
yyyyx4
deleted the
public/use_smaller_scalar_when_checking_kernel_polynomial
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code takes a generating set of the unit group, but as a comment in the code suggests, a set of generators for$(\mathbb Z/m)^\times/\pm$ suffices. The existing function $m$ is an odd prime power, so we may use it.
_least_semi_primitivecomputes such a semiprimitive root when