Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix broken pyright in CI #36639

Merged
merged 1 commit into from
Nov 5, 2023
Merged

fix broken pyright in CI #36639

merged 1 commit into from
Nov 5, 2023

Conversation

fchapoton
Copy link
Contributor

This is trying to fix our broken CI, where pyright complains about the type of PariError.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

Documentation preview for this PR (built with commit 76196ad; changes) is ready! 🎉

tobiasdiez
tobiasdiez approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the initiative. Your fix works and looks good to me (Thus marking it as blocker).

However, it reverts the changes of #36271 so I'm not sure if @mkoeppe is happy with it.

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 3, 2023

It's fine for now, I'll find a solution that is compatible with pyright in #35095, where this change was cherry-picked from.

@mkoeppe mkoeppe added this to the sage-10.2 milestone Nov 3, 2023
@vbraun vbraun merged commit 4533ffb into sagemath:develop Nov 5, 2023
19 of 22 checks passed
@fchapoton fchapoton deleted the fix_pyright_ci branch November 5, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

Assignees
No one assigned
Labels
p: blocker / 1
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.
4 participants
@fchapoton @mkoeppe @tobiasdiez @vbraun