sage.interfaces: Update # needs
#36656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
November 5, 2023 14:31
dcoudert
approved these changes
Nov 7, 2023
|
Thank you! |
|
merge conflict |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 4, 2023
As FriCAS is only used as an executable, this is straightforward; quite a number of systems has Fricas 1.3.8, so this is useful, too. The FriCAS pexpect interface now uses the new `Executable` feature to determine the absolute pathname of the fricas executable (unless executed remotely). This is made possible by a simple refactor of the `sage.interfaces.expect.Expect` class: Computing the effective command line is no longer done in `set_server_and_command` (called by `__init__`); it is delayed until an interface is started and needs the command line. - Fixes sagemath#35837 - Fixes sagemath#33575 Dependencies: The changes in `sage.interfaces` outside of `.expect` and `.fricas` are all from the following PR and do not need review. - Depends on sagemath#36656 (merged here) URL: sagemath#35838 Reported by: Dima Pasechnik Reviewer(s): Dima Pasechnik, François Bissey, Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 5, 2023
As FriCAS is only used as an executable, this is straightforward; quite a number of systems has Fricas 1.3.8, so this is useful, too. The FriCAS pexpect interface now uses the new `Executable` feature to determine the absolute pathname of the fricas executable (unless executed remotely). This is made possible by a simple refactor of the `sage.interfaces.expect.Expect` class: Computing the effective command line is no longer done in `set_server_and_command` (called by `__init__`); it is delayed until an interface is started and needs the command line. - Fixes sagemath#35837 - Fixes sagemath#33575 Dependencies: The changes in `sage.interfaces` outside of `.expect` and `.fricas` are all from the following PR and do not need review. - Depends on sagemath#36656 (merged here) URL: sagemath#35838 Reported by: Dima Pasechnik Reviewer(s): Dima Pasechnik, François Bissey, Matthias Köppe
|
Documentation preview for this PR (built with commit a403e8f; changes) is ready! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Checklist
Cherry-picked from #35095
⌛ Dependencies