Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capitals to Hopf, Lie, Coxeter by appropriate mechanism #36673

Merged
merged 2 commits into from
Dec 10, 2023

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Nov 7, 2023

This is adding a proper mechanism to have capitalized proper names in category names.

This is applied here to Coxeter, Lie and Hopf. Also Hecke and Weyl.

The important changes are in src/sage/categories/category.py

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have updated the documentation accordingly.

@fchapoton fchapoton requested a review from tscrim November 7, 2023 15:06
Copy link

github-actions bot commented Nov 7, 2023

Documentation preview for this PR (built with commit 6193042; changes) is ready! 🎉

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 7, 2023
…nism

    
This is adding a proper mechanism to have capitalized proper names in
category names.

This is applied here to Coxeter, Lie and Hopf. Also Hecke and Weyl.

The important changes are in `src/sage/categories/category.py`

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have updated the documentation accordingly.
    
URL: sagemath#36673
Reported by: Frédéric Chapoton
Reviewer(s): Kwankyu Lee
@vbraun vbraun merged commit edc7e02 into sagemath:develop Dec 10, 2023
18 of 22 checks passed
@fchapoton fchapoton deleted the capitals_Hopf branch December 10, 2023 14:01
@mkoeppe mkoeppe added this to the sage-10.3 milestone Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants