pep8 for axiom and sympy interfaces #36745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoeppe
reviewed
Nov 21, 2023
src/sage/interfaces/axiom.py
Outdated
| @@ -458,14 +457,14 @@ def _eval_line(self, line, reformat=True, allow_use_file=False, | |||
| return out | |||
| # out = out.lstrip() | |||
| i = out.find('\n') | |||
| out = out[i+1:] | |||
| out = out[i + 1:] | |||
There was a problem hiding this comment.
I think this is incorrect per PEP 8 - https://peps.python.org/pep-0008/#pet-peeves
"in a slice the colon acts like a binary operator, and should have equal amounts on either side (treating it as the operator with the lowest priority)."
There was a problem hiding this comment.
There is equal amounts of space on either side of :, namely, zero. I see no problem here.
There was a problem hiding this comment.
Ah, you meant
# Correct:
ham[lower+offset : upper+offset]
# Wrong:
ham[lower + offset:upper + offset]
You are right.
But personally I cannot agree with the recommendation. I like the "wrong" format :-)
|
Documentation preview for this PR (built with commit 8d8b28d; changes) is ready! 🎉 |
mkoeppe
approved these changes
Nov 22, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pep8 cleanup for the 2 modified files
📝 Checklist