Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rerun configure less often #37127

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Rerun configure less often #37127

merged 4 commits into from
Mar 25, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jan 21, 2024 •
edited
Loading

There's no need to re-run configure if only template files such as build/make/Makefile.in (see AC_CONFIG_FILES in configure.ac) change: It suffices to run config.status in this case.

Fixes #32119

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Feb 5, 2024
@mkoeppe mkoeppe requested a review from yyyyx4 February 25, 2024 18:39
kwankyu
kwankyu reviewed Mar 6, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@mkoeppe mkoeppe force-pushed the rerun_configure_less_often branch from 23fd884 to 8526c3e Compare March 8, 2024 03:15
kwankyu
kwankyu reviewed Mar 8, 2024
View reviewed changes
Makefile Show resolved Hide resolved
kwankyu
kwankyu approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 8, 2024

Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024

Documentation preview for this PR (built with commit 663c222; changes) is ready! 🎉

@kwankyu
Copy link
Collaborator

kwankyu commented Mar 8, 2024 •
edited
Loading

I wonder if the failed test in B&T is related...

Not related.

@vbraun vbraun merged commit ba8393e into sagemath:develop Mar 25, 2024
17 of 18 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

@jhpalmieri jhpalmieri Awaiting requested review from jhpalmieri

@yyyyx4 yyyyx4 Awaiting requested review from yyyyx4

Assignees

@mkoeppe mkoeppe

Labels
c: build p: minor / 4
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.

Makefile: If build/make/Makefile.in changes, only run ./config.status, not ... --recheck
3 participants
@mkoeppe @kwankyu @vbraun