Fix corners cases of free resolutions #37132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwankyu
changed the title
|
Documentation preview for this PR (built with commit 162163c; changes) is ready! 🎉 |
|
Thanks! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 24, 2024
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> as seen in ```sage sage: P2.<x,y,z> = ProjectiveSpace(QQ, 2) sage: S = P2.coordinate_ring() sage: I = S.ideal(0) sage: C = I.graded_free_resolution(); C S(0) <-- 0 sage: C[1] Ambient free module of rank 0 over the integral domain Multivariate Polynomial Ring in x, y, z over Rational Field sage: C[0] ------------------------------------------------------------------------ --- IndexError Traceback (most recent call last) Cell In[5], line 1 ----> 1 C[Integer(0)] File ~/GitHub/sage/src/sage/homology/free_resolution.py:426, in FiniteFreeResolution.__getitem__(self, i) 424 F = FreeModule(self._base_ring, 0) 425 elif i == self._length: --> 426 F = FreeModule(self._base_ring, self._maps[i - 1].ncols()) 427 else: 428 F = FreeModule(self._base_ring, self._maps[i].nrows()) IndexError: list index out of range sage: C.differential(1) ------------------------------------------------------------------------ --- IndexError Traceback (most recent call last) Cell In[6], line 1 ----> 1 C.differential(Integer(1)) File ~/GitHub/sage/src/sage/homology/free_resolution.py:489, in FiniteFreeResolution.differential(self, i) 487 elif i == self._length + 1: 488 s = FreeModule(self._base_ring, 0) --> 489 t = FreeModule(self._base_ring, self._maps[i - 2].ncols()) 490 m = s.hom(0, t) 491 elif i > self._length + 1: IndexError: list index out of range ``` <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#37132 Reported by: Kwankyu Lee Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 27, 2024
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> as seen in ```sage sage: P2.<x,y,z> = ProjectiveSpace(QQ, 2) sage: S = P2.coordinate_ring() sage: I = S.ideal(0) sage: C = I.graded_free_resolution(); C S(0) <-- 0 sage: C[1] Ambient free module of rank 0 over the integral domain Multivariate Polynomial Ring in x, y, z over Rational Field sage: C[0] ------------------------------------------------------------------------ --- IndexError Traceback (most recent call last) Cell In[5], line 1 ----> 1 C[Integer(0)] File ~/GitHub/sage/src/sage/homology/free_resolution.py:426, in FiniteFreeResolution.__getitem__(self, i) 424 F = FreeModule(self._base_ring, 0) 425 elif i == self._length: --> 426 F = FreeModule(self._base_ring, self._maps[i - 1].ncols()) 427 else: 428 F = FreeModule(self._base_ring, self._maps[i].nrows()) IndexError: list index out of range sage: C.differential(1) ------------------------------------------------------------------------ --- IndexError Traceback (most recent call last) Cell In[6], line 1 ----> 1 C.differential(Integer(1)) File ~/GitHub/sage/src/sage/homology/free_resolution.py:489, in FiniteFreeResolution.differential(self, i) 487 elif i == self._length + 1: 488 s = FreeModule(self._base_ring, 0) --> 489 t = FreeModule(self._base_ring, self._maps[i - 2].ncols()) 490 m = s.hom(0, t) 491 elif i > self._length + 1: IndexError: list index out of range ``` <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#37132 Reported by: Kwankyu Lee Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 29, 2024
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> as seen in ```sage sage: P2.<x,y,z> = ProjectiveSpace(QQ, 2) sage: S = P2.coordinate_ring() sage: I = S.ideal(0) sage: C = I.graded_free_resolution(); C S(0) <-- 0 sage: C[1] Ambient free module of rank 0 over the integral domain Multivariate Polynomial Ring in x, y, z over Rational Field sage: C[0] ------------------------------------------------------------------------ --- IndexError Traceback (most recent call last) Cell In[5], line 1 ----> 1 C[Integer(0)] File ~/GitHub/sage/src/sage/homology/free_resolution.py:426, in FiniteFreeResolution.__getitem__(self, i) 424 F = FreeModule(self._base_ring, 0) 425 elif i == self._length: --> 426 F = FreeModule(self._base_ring, self._maps[i - 1].ncols()) 427 else: 428 F = FreeModule(self._base_ring, self._maps[i].nrows()) IndexError: list index out of range sage: C.differential(1) ------------------------------------------------------------------------ --- IndexError Traceback (most recent call last) Cell In[6], line 1 ----> 1 C.differential(Integer(1)) File ~/GitHub/sage/src/sage/homology/free_resolution.py:489, in FiniteFreeResolution.differential(self, i) 487 elif i == self._length + 1: 488 s = FreeModule(self._base_ring, 0) --> 489 t = FreeModule(self._base_ring, self._maps[i - 2].ncols()) 490 m = s.hom(0, t) 491 elif i > self._length + 1: IndexError: list index out of range ``` <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#37132 Reported by: Kwankyu Lee Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 30, 2024
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> as seen in ```sage sage: P2.<x,y,z> = ProjectiveSpace(QQ, 2) sage: S = P2.coordinate_ring() sage: I = S.ideal(0) sage: C = I.graded_free_resolution(); C S(0) <-- 0 sage: C[1] Ambient free module of rank 0 over the integral domain Multivariate Polynomial Ring in x, y, z over Rational Field sage: C[0] ------------------------------------------------------------------------ --- IndexError Traceback (most recent call last) Cell In[5], line 1 ----> 1 C[Integer(0)] File ~/GitHub/sage/src/sage/homology/free_resolution.py:426, in FiniteFreeResolution.__getitem__(self, i) 424 F = FreeModule(self._base_ring, 0) 425 elif i == self._length: --> 426 F = FreeModule(self._base_ring, self._maps[i - 1].ncols()) 427 else: 428 F = FreeModule(self._base_ring, self._maps[i].nrows()) IndexError: list index out of range sage: C.differential(1) ------------------------------------------------------------------------ --- IndexError Traceback (most recent call last) Cell In[6], line 1 ----> 1 C.differential(Integer(1)) File ~/GitHub/sage/src/sage/homology/free_resolution.py:489, in FiniteFreeResolution.differential(self, i) 487 elif i == self._length + 1: 488 s = FreeModule(self._base_ring, 0) --> 489 t = FreeModule(self._base_ring, self._maps[i - 2].ncols()) 490 m = s.hom(0, t) 491 elif i > self._length + 1: IndexError: list index out of range ``` <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#37132 Reported by: Kwankyu Lee Reviewer(s): Travis Scrimshaw
3 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 18, 2024
I have implemented the `automatic size labeler`, which now assigns labels to pull requests based on the number of lines changed **Minimal** Typically involves very small changes, bug fixes, or updates that require only a few lines of code, often less than 50. sagemath#37208 sagemath#37146 sagemath#37043 **Small** Involves more substantial changes than minimal, potentially adding new features or making modifications to existing ones. The range is usually between 50 to 100 lines of code. sagemath#37152 sagemath#37132 **Moderate** Represents a significant portion of the codebase being modified, such as adding new features, refactoring, or making extensive changes to existing functionalities. This might involve between 100 to 300 lines of code. sagemath#36919 sagemath#37112 **Large** Involves substantial and complex changes across various parts of the codebase. This could include major architectural changes, the introduction of new modules, or a significant overhaul of existing features, often exceeding 300 lines of code. sagemath#37125 sagemath#36977 sagemath#36972 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. Fixes: sagemath#37254 URL: sagemath#37262 Reported by: Aman Moon Reviewer(s): Sebastian Oehms
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 20, 2024
I have implemented the `automatic size labeler`, which now assigns labels to pull requests based on the number of lines changed **Minimal** Typically involves very small changes, bug fixes, or updates that require only a few lines of code, often less than 50. sagemath#37208 sagemath#37146 sagemath#37043 **Small** Involves more substantial changes than minimal, potentially adding new features or making modifications to existing ones. The range is usually between 50 to 100 lines of code. sagemath#37152 sagemath#37132 **Moderate** Represents a significant portion of the codebase being modified, such as adding new features, refactoring, or making extensive changes to existing functionalities. This might involve between 100 to 300 lines of code. sagemath#36919 sagemath#37112 **Large** Involves substantial and complex changes across various parts of the codebase. This could include major architectural changes, the introduction of new modules, or a significant overhaul of existing features, often exceeding 300 lines of code. sagemath#37125 sagemath#36977 sagemath#36972 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. Fixes: sagemath#37254 URL: sagemath#37262 Reported by: Aman Moon Reviewer(s): Sebastian Oehms
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 25, 2024
I have implemented the `automatic size labeler`, which now assigns labels to pull requests based on the number of lines changed **Minimal** Typically involves very small changes, bug fixes, or updates that require only a few lines of code, often less than 50. sagemath#37208 sagemath#37146 sagemath#37043 **Small** Involves more substantial changes than minimal, potentially adding new features or making modifications to existing ones. The range is usually between 50 to 100 lines of code. sagemath#37152 sagemath#37132 **Moderate** Represents a significant portion of the codebase being modified, such as adding new features, refactoring, or making extensive changes to existing functionalities. This might involve between 100 to 300 lines of code. sagemath#36919 sagemath#37112 **Large** Involves substantial and complex changes across various parts of the codebase. This could include major architectural changes, the introduction of new modules, or a significant overhaul of existing features, often exceeding 300 lines of code. sagemath#37125 sagemath#36977 sagemath#36972 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. Fixes: sagemath#37254 URL: sagemath#37262 Reported by: Aman Moon Reviewer(s): Sebastian Oehms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as seen in
📝 Checklist
⌛ Dependencies