-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade shipped suitesparse components to 7.8.0 #37204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
please feel free to adjust tags accordingly |
the failing doctest
looks irrelevant to this PR |
Sorry, I have been busy. I think I need to explain some of the options I set with cmake a little bit more before shipping it. |
Since all I have done in the last commit is add some text, I will label it positive review as approved by Dima. |
Has this been tested on more than one machine? "CI Linux Incremental" is only being run now that the label "c: packages: standard" is set. |
Well, some CI ran before, but yes, I do not think it ran on Mac OS before for example. I'll just push your comma change and remove the positive review label until the full CI ran. |
I'm running the full CI Linux in https://github.com/mkoeppe/sage/actions/runs/7748353404 and CI macOS in https://github.com/mkoeppe/sage/actions/runs/7748353409 |
Various failures:
(https://github.com/mkoeppe/sage/actions/runs/7748353404/job/21130813895#step:14:1077, minimal-pre / linux (ubuntu-lunar, minimal)) Likewise on many other platforms. This sounds familiar from the last attempt. I'll take a closer look in the next days. |
The cmake version tightening was already on the old branch, can just cherry pick from there - sagemath/sagetrac-mirror@6f4032e |
Sounds like something that's overdue in any case. I will deal with it ASAP. |
There are three build failure of suitesparse 7.6.0 so far but I do not have enough of the build log to make a diagnostic. |
You can see the full build log in the section "Print out logs for immediate inspection", e.g. https://github.com/sagemath/sage/actions/runs/7752508002/job/21142181161?pr=37204, clock on the triangle to expand the collapsed portion |
Thanks, found it. There is mismatch between system gcc (13) and sage's gfortran (12). I am suspecting that's the issue. I think turning off fortran should be OK, so I'll try that. |
IIRC, that was also the issue last time. It may be worth trying if just disabling LTO would solve this. |
What Flag would that be? |
|
|
Documentation preview for this PR (built with commit c53fac1; changes) is ready! 🎉 |
The last conda tests appear to be stuck. The failing tests so far look unrelated. |
OK, retrying here, will move 7.8.0 (7.8.1 is identical apart from graphblas which we do not use). |
This PR is now about suitesparse 7.8.0 |
Portability tests (with a bunch of other upgrades) at https://github.com/mkoeppe/sage/actions/runs/10484245959 |
Builds and tests OK on macOS (x86_64) with homebrew |
Looking good, thanks for preparing this upgrade! |
<!-- ^^^^^ Upgrade the shipped suitesparse components to 7.6.0 --> This is to fix sagemath#37192 and supersedes sagemath#34206 The new cmake superbuild is leveraged to only build the suitesparse components of interest * amd * camd * colamd * ccolamd * cholmod * umfpack ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#37204 Reported by: François Bissey Reviewer(s): Dima Pasechnik, Matthias Köppe
https://github.com/sagemath/sage/actions/runs/10691572603/job/29638332632#step:4:3332 |
This is to fix #37192 and supersedes #34206
The new cmake superbuild is leveraged to only build the suitesparse components of interest
📝 Checklist
⌛ Dependencies