Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directly convert PermutationGroup element into sized Permutation #37288

Merged
merged 12 commits into from
Mar 25, 2024
Merged

Directly convert PermutationGroup element into sized Permutation #37288

Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
683513b
Fixed the problem with direct making a permutation from a permutation…
RuchitJagodara Feb 10, 2024
90971f0
Made the changes efficient
RuchitJagodara Feb 10, 2024
7e1f3fc
Added try except block to cover all cases
RuchitJagodara Feb 11, 2024
b7b05c6
Check for specific type while x is not in correct form
RuchitJagodara Feb 12, 2024
f444d32
Corrected the test documentation
RuchitJagodara Feb 12, 2024
9ced783
Use _from_permutation_group_element function instead of updating x
RuchitJagodara Feb 15, 2024
7328410
Updated the test case
RuchitJagodara Feb 15, 2024
f8d9d70
Improve the quality of test case
RuchitJagodara Feb 18, 2024
0d2a944
Added a line in test case to ensure that conversion was successfull
RuchitJagodara Feb 18, 2024
c4a60bd
Make test more robust for the function _element_constructor_
RuchitJagodara Feb 25, 2024
6bc3152
Correct variable names in test
RuchitJagodara Feb 26, 2024
54747b6
Make tests more robust
RuchitJagodara Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/sage/combinat/permutation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7092,7 +7092,17 @@ def _element_constructor_(self, x, check=True):
[1, 4, 5, 2, 3, 6]
sage: Permutations(6)(x) # known bug
[1, 4, 5, 2, 3, 6]

Ensure that :issue:`37284` is fixed::

sage: PG = PermutationGroup([[(1,2,3),(5,6)],[(7,8)]])
sage: P5 = Permutations(8)
sage: p = PG.an_element()
sage: P5(p).parent()
Standard permutations of 8
RuchitJagodara marked this conversation as resolved.
Show resolved Hide resolved
"""
if isinstance(x, PermutationGroupElement):
return self. _from_permutation_group_element(x)
if len(x) < self.n:
x = list(x) + list(range(len(x) + 1, self.n + 1))
return self.element_class(self, x, check=check)
Expand Down
Loading