allow the warning about root isolation failures in CBF[x] to be turned off #37357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 7cbf585; changes) is ready! 🎉 |
|
please add the new keyword to the doc |
|
Thanks for the review, I had completely forgotten about this PR!
On Thursday, 26 September 2024 08:20:41 CEST Frédéric Chapoton wrote:
please add the new keyword to the doc
I'm not sure where to put it. I already added an example with the new
keyword to the docs of the main roots() method; I feel that adding
something in the INPUT block there for a keyword that only applies to a
specific coefficient ring would be more confusing than anything. And the
docstring of the interval `_roots_univariate_polynomial` method does not
look like a good place either. What would you suggest?
|
|
ok, then let's see if the tests pass and I will set to positive |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.