Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark some slow tests as slow #37363

Merged
merged 14 commits into from
Jul 24, 2024
Merged

Mark some slow tests as slow #37363

merged 14 commits into from
Jul 24, 2024

Conversation

grhkm21
Copy link
Contributor

@grhkm21 grhkm21 commented Feb 15, 2024

Fixes #37356.

I ran sage -t --warn-long 5 groups schemes rings and added "# long time" when I see fit. There are a few tests that I didn't add.

@grhkm21
Copy link
Contributor Author

grhkm21 commented Feb 17, 2024 •
edited
Loading

@Pietro-D Please don't positive review when doctests fail (I forgot to mark a block as # long time)

But I cannot fix it right now, I am busy with some other work.

@Pietro-D
Copy link

@Pietro-D Please don't positive review when doctests fail (I forgot to mark a block as # long time)

But I cannot fix it right now, I am busy with some other work.

Sorry, I am new to open source contribution and I am still understanding how the process works

Pietro-D
Pietro-D reviewed Feb 17, 2024
View reviewed changes
Copy link

@Pietro-D Pietro-D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error traceback indicates that there was an issue with the initialization of the Sage environment, possibly related to the GAP interface.

@grhkm21
Copy link
Contributor Author

grhkm21 commented Feb 18, 2024

Thanks everyone (why are there so many people haha), I am away these few days so this will be stalled for a few days. Sorry for that!

@grhkm21 grhkm21 requested a review from mkoeppe February 19, 2024 12:25
@grhkm21 grhkm21 requested a review from mkoeppe February 21, 2024 12:42
mkoeppe
mkoeppe approved these changes Feb 25, 2024
View reviewed changes
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grhkm21 @mkoeppe
remove extra spaces
b264a86 
Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>
@grhkm21
Copy link
Contributor Author

grhkm21 commented Feb 25, 2024

Thanks!

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2024 •
edited
Loading

Documentation preview for this PR (built with commit f570e7a; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@vbraun
Copy link
Member

vbraun commented Mar 23, 2024

Please do not set tickets with failing CI tests to positive review.

Needs fixing:

TypeError: unbound method CategoryObject.base_ring() needs an argument

@grhkm21
Copy link
Contributor Author

grhkm21 commented Jun 20, 2024

Sorry for the delay, I have fixed the problem. @mkoeppe do you mind reviewing this again? (Just look at the latest commit, should be trivial)

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 20, 2024

Test failure in CI

@grhkm21
Copy link
Contributor Author

grhkm21 commented Jun 20, 2024

hopefully ifxed

grhkm21 and others added 3 commits June 20, 2024 05:37
@grhkm21 @mkoeppe
Update src/sage/algebras/fusion_rings/f_matrix.py
24f2356 
Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>
@grhkm21 @mkoeppe
Update src/sage/combinat/root_system/root_lattice_realization_algebra…
4f80412 
…s.py

Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>
@grhkm21 @mkoeppe
Update src/sage/rings/polynomial/polynomial_quotient_ring_element.py
b00a44c 
Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>
mkoeppe
mkoeppe approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

grhkm21 and others added 3 commits June 20, 2024 05:50
@grhkm21 @mkoeppe
Update src/sage/combinat/root_system/root_lattice_realization_algebra…
450b22d 
…s.py

Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>
@grhkm21 @mkoeppe
Update src/sage/combinat/root_system/root_lattice_realization_algebra…
e9c360e 
…s.py

Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>
@grhkm21 @mkoeppe
Update src/sage/combinat/root_system/root_lattice_realization_algebra…
f570e7a 
…s.py

Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>
@vbraun vbraun merged commit 27cfbba into sagemath:develop Jul 24, 2024
20 checks passed
@mkoeppe mkoeppe added this to the sage-10.5 milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pietro-D Pietro-D Pietro-D approved these changes

@gmou3 gmou3 gmou3 left review comments

@mkoeppe mkoeppe mkoeppe approved these changes

Assignees
No one assigned
Labels
p: minor / 4 t: tests v: small
Projects
None yet
Milestone
sage-10.5
Development

Successfully merging this pull request may close these issues.

very slow tests in polynomial_element.pyx (splitting_field)
5 participants
@grhkm21 @Pietro-D @vbraun @mkoeppe @gmou3