Strength 2 Covering Array constructions #37372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
call them based on inputted paramters. Added methods include direct implementation of optimal arrays in the database of small combinatorial designs, methods that create a CA(N,t=2,k,v=2), for either k or N inputted and a recursive method that removes columns from a larger array. Added required documentation and reference for new methods.
|
Documentation preview for this PR (built with commit 0aa6f44; changes) is ready! 🎉 |
mkoeppe
reviewed
Apr 10, 2024
mkoeppe
reviewed
Apr 10, 2024
mkoeppe
reviewed
Apr 10, 2024
mkoeppe
reviewed
Apr 10, 2024
mkoeppe
reviewed
Apr 10, 2024
mkoeppe
reviewed
Apr 10, 2024
mkoeppe
reviewed
Apr 10, 2024
mkoeppe
reviewed
Apr 10, 2024
sraaphorst
suggested changes
Apr 13, 2024
more generally so it does not need to be changed if things are added. Also edited some functions to produce the same output more efficiently. Fixed some formatting and punctuation errors.
|
The Lint check is failing because of a 'check == True' statement I made. I used it because the function 'orthogonal_array' may output 'Unknown', in which case I would like to ignore it. What is the recommended way that I handle this? |
mkoeppe
reviewed
Jun 17, 2024
mkoeppe
reviewed
Jun 17, 2024
Changed ValueError to NotImplementedError
Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>
mkoeppe
reviewed
Jul 31, 2024
mkoeppe
reviewed
Jul 31, 2024
Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 5, 2024
This patch aims to add functionality to the covering arrays module that was recently added to SageMath. It adds methods that create many covering arrays of strength 2 that can later be used for recursive constructions as well. Specifically: added methods to generate covering arrays and a main CA function to call them based on inputted parameters. Added methods include direct implementation of optimal arrays in the database of small combinatorial designs, methods that create a CA(N,t=2,k,v=2), for either k or N inputted and a recursive method that removes columns from a larger array. Added required documentation and reference for new methods. This fixes sagemath#37371 URL: sagemath#37372 Reported by: Aaron Dwyer Reviewer(s): Aaron Dwyer, Matthias Köppe, Sebastian Raaphorst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch aims to add functionality to the covering arrays module that was recently added to SageMath. It adds methods that create many covering arrays of strength 2 that can later be used for recursive constructions as well.
Specifically: added methods to generate covering arrays and a main CA function to call them based on inputted parameters.
Added methods include direct implementation of optimal arrays in the database of small combinatorial designs, methods that create a CA(N,t=2,k,v=2), for either k or N inputted and a recursive method that removes columns from a larger array. Added required documentation and reference for new methods.
This fixes #37371