-
-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update conda lock files #37436
Update conda lock files #37436
Conversation
As noted in sagemath#37024 and in sagemath#36489, `sage-conf` is actually not needed on a few systems now. For this reason, we make the installation of it optional (as there are no optional install requires as far as I know, this means we remove it from `pyproject.toml` and `setup.cfg`). We also remove it from "install all dependencies via conda" as its not needed there.
a9d89e7
to
43ea952
Compare
Tests are passing, would be nice to still merge it in this release cycle as it includes a few nice improvements (notably the docs currently don't build under conda due the missing inline tabs dependency that has been added in #37056 without updating the lock files). |
Documentation preview for this PR (built with commit c03018d; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The Sage Code of Conduct Committee is setting this back to needs review for now based on it being part of @dimpase's reaction to our decision on #36181, #36561, #36676, #36951, #36964, #37351, #36999, and #36941. It can, of course, be granted positive review at a future date, and will be subject to the policy on disputed PRs as normal. |
Unfortunately it's not clear what is "disputed" in this PR. (As one of the people who care a lot about conda, I'd love to cast my vote here but I would like to understand both sides first.) Btw., I think that the PR description is somehow broken. The actual description of the PR is inside the checklist section. (While you're at it, you might want to check the check list or remove it so it's immediately clear that nothing obvious is missing from that list.) |
@saraedum This PR is marked as "disputed" because it bundles the disputed #37138. The latter sabotages the PyPI distribution strategy (clearly documented in https://pypi.org/project/sage-conf/). |
Updating the conda-lock file does not require this bundling. Per PR description here "the configure script fails for some reason" -- this should be debugged, not papered over. |
Since the dispute is about a dependency that is also explicitly listed as a dependency here, could the "disputed" be removed then? (Otherwise, this is imho confusing for people trying to cast votes, like myself.) |
Since there is nothing controversial on this specific PR at the moment but rather its dependency needs a vote, I removed the disputed label. |
outdated |
📝 Checklist
Update (and minimize) the conda lock files.
⌛ Dependencies