Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formal deprecation of old group class #37449

Merged
merged 3 commits into from
Mar 31, 2024
Merged

formal deprecation of old group class #37449

merged 3 commits into from
Mar 31, 2024

Conversation

fchapoton
Copy link
Contributor

trying to finally get rid of the auld group class

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

mkoeppe
mkoeppe reviewed Feb 24, 2024
View reviewed changes
src/sage/groups/group.pyx Outdated Show resolved Hide resolved
mkoeppe
mkoeppe reviewed Feb 24, 2024
View reviewed changes
src/sage/groups/old.pyx Outdated Show resolved Hide resolved
mkoeppe
mkoeppe reviewed Feb 24, 2024
View reviewed changes
src/sage/groups/old.pyx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 4cff0fe; changes) is ready! 🎉

@vbraun vbraun merged commit 3d59d9c into sagemath:develop Mar 31, 2024
22 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Mar 31, 2024
@fchapoton fchapoton deleted the deprecate_old_group_class branch April 1, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkoeppe mkoeppe mkoeppe left review comments

Assignees
No one assigned
Labels
c: group theory t: refactoring
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
3 participants
@fchapoton @mkoeppe @vbraun