-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing docstring in random testing for quaternion_algebra.py
#37489
Conversation
I don't know whether to label this as minor, as it's a small bug, or blocker, as it currently results in CI failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good enough to me. I guess blocker
makes sense since it's a really trivial change (not much can go wrong by merging it), and the failure being present in a release could waste quite a few people's time.
Thanks Lorenz :) |
Relabelling to |
@vbraun following Lorenz's message -- this bug is causing repeated CI failures in my PR considering the tiny footprint of this PR it would be nice to get it included? |
Documentation preview for this PR (built with commit 949d94e; changes) is ready! 🎉 |
The current code:
Causes a doctest to fail as a
Ring morphism
is expected but whenO0 == O1
then instead aRing endomorphism
is computed instead.We simply truncate the expected output for the random testing from
Ring morphism
toRing ...
fixing the failure.Fixes #37488