Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix debian.txt for qhull #37521

Merged
merged 1 commit into from
Mar 31, 2024
Merged

fix debian.txt for qhull #37521

merged 1 commit into from
Mar 31, 2024

Conversation

dimpase
Copy link
Member

@dimpase dimpase commented Mar 2, 2024

added missing Debian package for qhull

added missing package
Copy link

github-actions bot commented Mar 2, 2024

Documentation preview for this PR (built with commit 25e05bb; changes) is ready! 🎉

@kcrisman
Copy link
Member

kcrisman commented Mar 3, 2024

Did you add the wrong reviewer by mistake? I know almost nothing about Debian and how it works, nor the syntax for this. I didn't see that the Debian files for other packages were this different than (say) Arch or Homebrew, but maybe qhull is unusual that way:

So does this just say which packages to pull in from Debian? I notice their last time stamp is 2015, hope that's okay.

@dimpase
Copy link
Member Author

dimpase commented Mar 3, 2024

buster is an old Debian. current stable is bookworm

it's really is a trivial fix. qhull is used both as a library and an an executable, and in bookworm they are in separate packages

@dimpase
Copy link
Member Author

dimpase commented Mar 3, 2024

yes, these records are just listing OS packages to be installed

@kcrisman
Copy link
Member

kcrisman commented Mar 4, 2024

buster is an old Debian. current stable is bookworm

Haha, I didn't even look at that piece of the URL.

Okay, LGTM.

@vbraun vbraun merged commit 256b6b7 into sagemath:develop Mar 31, 2024
19 of 38 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants