Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refresh sha_tate.py #37556

Merged
merged 2 commits into from
Mar 31, 2024
Merged

refresh sha_tate.py #37556

merged 2 commits into from
Mar 31, 2024

Conversation

fchapoton
Copy link
Contributor

just a small refreshing of the modified file, with minor changes in doc and code

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

S17A05
S17A05 reviewed Mar 6, 2024
View reviewed changes
Copy link
Member

@S17A05 S17A05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing, otherwise LGTM.

src/sage/schemes/elliptic_curves/sha_tate.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

Documentation preview for this PR (built with commit a818d2e; changes) is ready! 🎉

S17A05
S17A05 approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@S17A05 S17A05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@vbraun vbraun merged commit 8af3c37 into sagemath:develop Mar 31, 2024
15 of 16 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Mar 31, 2024
@fchapoton fchapoton deleted the refresh_sha_tate branch April 1, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S17A05 S17A05 S17A05 approved these changes

Assignees
No one assigned
Labels
c: elliptic curves
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
4 participants
@fchapoton @S17A05 @vbraun @mkoeppe