Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend the definition of q-binomial coefficients to (k > 0, n < 0) #37599

Merged
merged 3 commits into from
Mar 31, 2024

Conversation

fchapoton
Copy link
Contributor

This is extending the domain of the q-binomial coefficients.

This is done by polynomiality wrt n, for k >= 0.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. I have one minor code stylistic change, and one question. Should the default ring for the $n &lt; 0$ case be $\mathbb{Z}[q,q^{-1}]$ instead of the fraction field of $\mathbb{Z}[q]$? This has properties closer to the polynomial ring and arithmetic is faster. What do you think?

src/sage/combinat/q_analogues.py Outdated Show resolved Hide resolved
fchapoton and others added 2 commits March 12, 2024 20:03
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
@fchapoton
Copy link
Contributor Author

yes, right, this is natural. Done, also for q_int.

Copy link

Documentation preview for this PR (built with commit 1e646f1; changes) is ready! 🎉

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

(Personally, I am not a fan of polygen as it is less explicit, but that's just my preference.)

@vbraun vbraun merged commit f1bc088 into sagemath:develop Mar 31, 2024
16 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Mar 31, 2024
@fchapoton fchapoton deleted the q_binomial_extended branch April 1, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants