Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphs.triangulations(3) cannot return a triangle #37602

Merged
merged 1 commit into from
Mar 31, 2024
Merged

graphs.triangulations(3) cannot return a triangle #37602

merged 1 commit into from
Mar 31, 2024

Conversation

dcoudert
Copy link
Contributor

Fixes #37562.

As proposed in #37562 (comment), this PR adds a doctest showing that graphs.triangulations(3) returns nothing.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@dcoudert dcoudert mentioned this pull request Mar 13, 2024
Closed
2 tasks
@dcoudert dcoudert self-assigned this Mar 13, 2024
@dcoudert dcoudert requested a review from tscrim March 13, 2024 10:46
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 47bb618; changes) is ready! 🎉

tscrim
tscrim approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun vbraun merged commit 67b2615 into sagemath:develop Mar 31, 2024
19 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

Assignees

@dcoudert dcoudert

Labels
c: graph theory t: enhancement
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.

graphs.triangulations(3) does not return the triangle
4 participants
@dcoudert @tscrim @vbraun @mkoeppe