src/sage/schemes: Doctest cosmetics #37609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiacomoPope
reviewed
Mar 14, 2024
| @@ -108,15 +108,15 @@ def c4c6_model(c4, c6, assume_nonsingular=False): | |||
|
|
|||
| - ``c4``, ``c6`` -- elements of a number field | |||
|
|
|||
| - ``assume_nonsingular`` (boolean, default False) -- if True, | |||
| - ``assume_nonsingular`` (boolean, default ``False``) -- if ``True``, | |||
| check for integrality and nosingularity. | |||
|
|
|||
| OUTPUT: | |||
|
|
|||
| The elliptic curve with a-invariants [0,0,0,-c4/48,-c6/864], whose | |||
| c-invariants are the given c4, c6. If the supplied invariants are | |||
There was a problem hiding this comment.
General comment, should we do c_4 for latex, double backticks for code or leave c4 as c4 in plaintest? This applies to many functions in this file.
There was a problem hiding this comment.
Probably formatting as LaTeX would be good here, but I'm not going to do it in this PR.
I'll be happy to review a follow-up PR that makes further improvements.
There was a problem hiding this comment.
Actually I found a moment to take care of some of these markup changes in this file. That's 74c43cd
Co-authored-by: Giacomo Pope <44242839+GiacomoPope@users.noreply.github.com>
Co-authored-by: Giacomo Pope <44242839+GiacomoPope@users.noreply.github.com>
Co-authored-by: Giacomo Pope <44242839+GiacomoPope@users.noreply.github.com>
GiacomoPope
reviewed
Mar 15, 2024
Co-authored-by: Giacomo Pope <44242839+GiacomoPope@users.noreply.github.com>
Co-authored-by: Giacomo Pope <44242839+GiacomoPope@users.noreply.github.com>
Co-authored-by: Giacomo Pope <44242839+GiacomoPope@users.noreply.github.com>
|
Thanks for the edits! Good to go now? |
|
Documentation preview for this PR (built with commit 86143e8; changes) is ready! 🎉 |
|
Yep! LGTM. Thanks so much to taking the time to clean these things up. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard reformatting of doctests and their outputs
Split out from #35095
📝 Checklist
⌛ Dependencies