-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style AUTHORS, INPUT, OUTPUT, EXAMPLES, etc. #37614
base: develop
Are you sure you want to change the base?
Conversation
7efe570
to
dba57f5
Compare
52e4c10
to
497d943
Compare
Why remove the colons? |
The section titles are now in bold face, that I thought makes the colon dispensable. Which do you like?
We may also style "EXAMPLES:" differently from "INPUT" and "OUTPUT". What do you think? |
Or we may add when needed: OUTPUT: a list of integers OUTPUT
This is choice (5). |
I chose to go with (3) with colon. To balance, I reduced the boldness (the weight). |
Experimenting with (5). Let's see. |
Which do you like? Vote on your preference
INPUT:
INPUT
INPUT:
INPUT
INPUT:
OUTPUT: a list of integers OUTPUT
|
+1 for (6) |
In 6, doesn't Input always have following text? |
If this has to be fixed in sage, I would rather stick to something standard and existent in the Python world, namely either
|
Sorry for being obscure. I modified the description. |
Note that this PR is about the cosmetic change in the rendered docstring by Sphinx. The format of the source docstring doesn't change. Your suggestion is about the source format. It should be a separate PR if you are interested in it. (There is already one if you look for it.) This PR is not about that. On the other hand, I like the current format, simple and clear :-) |
1 Best to just keep it simple. |
1 ... for the same reason as @tscrim + the sample pages in the PR description look bad to me: the colons are gone and the section titles do appear bold in my browser (Firefox). |
0d47ec3
to
af80da4
Compare
Documentation preview for this PR (built with commit 00cd01e; changes) is ready! 🎉 |
Ready for review again. The styling to AUTHORs section is the main thing of this PR. The stylings to INPUT, OUTOUT, etc. was dropped respecting the voting result (1). However I keep the (non-running) code for possible change in future. |
To make them look better.
Sample pages:
https://deploy-preview-37614--sagemath.netlify.app/html/en/reference/probability/sage/probability/probability_distribution
https://deploy-preview-37614--sagemath.netlify.app/html/en/reference/structure/sage/structure/formal_sum.html#formal-sums
📝 Checklist
⌛ Dependencies