Ensure the degree() method of Polynomial_generic_dense_inexact returns an Integer
#37622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiacomoPope
added
p: minor / 4
s: needs review
t: refactoring
and removed
t: refactoring
labels
|
Documentation preview for this PR (built with commit fb3e063; changes) is ready! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the testing of a bunch of new hyperelliptic curve code things, I keep finding cases where the degree of polynomials is returned as an
intinstead ofInteger. Here's another fix for the case when we have polynomials over Eisenstein extensions of p-adics.Fixes: #37621