Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FareySymbol: set aspect_ratio to one in graph of fundamental domain. #37728

Merged
merged 2 commits into from
Jul 24, 2024
Merged

FareySymbol: set aspect_ratio to one in graph of fundamental domain. #37728

merged 2 commits into from
Jul 24, 2024

Conversation

monien
Copy link
Contributor

@monien monien commented Apr 2, 2024 •
edited
Loading

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024 •
edited
Loading

Documentation preview for this PR (built with commit f3cbc41; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@monien
Copy link
Contributor Author

monien commented Apr 5, 2024

No further comment or update of the documentation is required. This is a bug fix (the aspect_ratio of graphs was globally changed to a value different from 1, which means a circle is display as an ellipse). The problem is also apparent in hyperbolic_arc etc.

fchapoton
fchapoton approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks

@vbraun vbraun merged commit 81734ed into sagemath:develop Jul 24, 2024
18 checks passed
@mkoeppe mkoeppe added this to the sage-10.5 milestone Jul 25, 2024
@monien monien deleted the farey_symbols branch July 29, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchapoton fchapoton fchapoton approved these changes

Assignees
No one assigned
Labels
c: graphics c: modular forms v: minimal
Projects
None yet
Milestone
sage-10.5
Development

Successfully merging this pull request may close these issues.
4 participants
@monien @fchapoton @vbraun @mkoeppe