-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dist.yml
: Download optional/experimental tarballs for GitHub Release assets
#37762
Conversation
https://github.com/mkoeppe/sage/actions/runs/8585436817/job/23526820138#step:9:864
|
729fbd5
to
d3e0537
Compare
dist.yml
: Download optional/experimental tarballs for GitHub Release assets
Documentation preview for this PR (built with commit a055882; changes) is ready! 🎉 |
d3e0537
to
e93c25b
Compare
…oo for the release asset
…experimental tarballs
…al tarballs without upstream
…tributable tarballs
…move zombie package parts
Removed the fix for the symengine_py upstream_url here; it's now on #37726. |
Are these Release assets distributed from somewhere else or just from the github site? Is it okay to bloat release assets? Some people may not prefer swollen tarballs with optional and experimental packages. I don't know as I never downloaded the tarballs for my use... |
…e, remove periods
All these files are also on our mirrors. Making them available as release assets makes it faster and more robust for users to download the files because of the use of GitHub's CDN.
This PR does not change what is in the large self-contained Sage release tarball. The tarball will still only contain the upstream tarballs of standard packages. |
|
You mean that the files contained in the Release assets, not the Release assets themselves? This PR just makes Release assets bigger by adding optional (not huge) and experimental packages. So if someone was using the Release assets, then he would experience longer download time after this PR. Can you estimate how much longer? Anyway, I agree that the Release assets don't need to be the same with the Sage release tarball... |
On Fri, May 10, 2024 at 4:04 PM Kwankyu Lee ***@***.***> wrote:
Are these Release assets distributed from somewhere else or just from the
github site?
All these files are also on our mirrors.
You mean that the files contained in the Release assets, not the Release
assets themselves?
"Release assets" are the files that you see listed in a GitHub release such
as https://github.com/sagemath/sage/releases/tag/10.3
This PR just makes Release assets bigger by adding optional (not huge) and
experimental packages.
It does not make any asset bigger; it just adds more of them.
So if someone was using the Release assets, then he would experience
longer download time after this PR.
No.
|
Ah, I see. Thanks. |
I was only looking at LGTM. |
Thank you! |
… for GitHub Release assets <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> - Fixes sagemath#37752, at least for the non-"huge" tarballs (we skip the "huge" tarballs here). - More options for `sage -package download` (a subset of what `sage -package list` supports) - Also remove some zombie package files Test run: https://github.com/mkoeppe/sage/actions/workflows/dist.yml ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - Depends on sagemath#37099 (merged to resolve merge conflict) URL: sagemath#37762 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee, Matthias Köppe
… for GitHub Release assets <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> - Fixes sagemath#37752, at least for the non-"huge" tarballs (we skip the "huge" tarballs here). - More options for `sage -package download` (a subset of what `sage -package list` supports) - Also remove some zombie package files Test run: https://github.com/mkoeppe/sage/actions/workflows/dist.yml ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - Depends on sagemath#37099 (merged to resolve merge conflict) URL: sagemath#37762 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee, Matthias Köppe
sage -package download
(a subset of whatsage -package list
supports)Test run: https://github.com/mkoeppe/sage/actions/workflows/dist.yml
📝 Checklist
⌛ Dependencies