Remove unnecessary forcing to univariate #38151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhutz
suggested changes
Jun 4, 2024
|
Documentation preview for this PR (built with commit 6ad33ef; changes) is ready! 🎉 |
S17A05
reviewed
Jun 5, 2024
|
Hints:
|
Co-authored-by: Sebastian A. Spindler <153911337+S17A05@users.noreply.github.com>
Co-authored-by: Sebastian A. Spindler <153911337+S17A05@users.noreply.github.com>
Nathabolin
changed the title
bhutz
approved these changes
Jun 17, 2024
1 task
Nathabolin
changed the title
Nathabolin
changed the title
2 tasks
|
What needs to be done for this to be accepted? or is it accepted? |
Nathabolin
changed the title
This is accepted, it just needs some time to be merged since the release of Sage 10.4 is currently being prepared, and afaik only urgent stuff is getting merged right now. Also merging the new develop-branch into your PR resets the "positive review"-label, so you should avoid it unless there are merge conflicts that need to be resolved. |
|
Good to know thank you so much |
kwankyu
reviewed
Jul 4, 2024
| @@ -8437,6 +8437,14 @@ def normal_form(self, return_conjugation=False): | |||
| To: Finite Field in z2 of size 3^2 | |||
| Defn: 1 |--> 1 | |||
|
|
|||
| Fixes :issue:`38012` by not forcing univariate polynomial to be univariate:: | |||
|
|
|||
| sage: R.<z> = PolynomialRing(QQ) | |||
There was a problem hiding this comment.
The comment says an implementation detail that is not understandable by a user. The usual way to introduce a test (example) for a fix is
TEST:
Check that :issue:`38012` is fixed::
sage: R.<z> = PolynomialRing(QQ)
|
Please correct the PR title. |
Nathabolin
changed the title
Nathabolin
changed the title
mkoeppe
changed the title
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 25, 2024
…nomialIdeal`, `is_MPolynomialRing`, `is_MPowerSeries`, `is_PolynomialQuotientRing`, `is_PolynomialRing`, `is_PolynomialSequence`, `is_PowerSeries`, `is_QuotientRing`
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
Part of:
- sagemath#32414
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
- Depends on sagemath#38151 (merged here)
URL: sagemath#38266
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 31, 2024
…nomialIdeal`, `is_MPolynomialRing`, `is_MPowerSeries`, `is_PolynomialQuotientRing`, `is_PolynomialRing`, `is_PolynomialSequence`, `is_PowerSeries`, `is_QuotientRing`
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
Part of:
- sagemath#32414
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
- Depends on sagemath#38151 (merged here)
URL: sagemath#38266
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 2, 2024
…nomialIdeal`, `is_MPolynomialRing`, `is_MPowerSeries`, `is_PolynomialQuotientRing`, `is_PolynomialRing`, `is_PolynomialSequence`, `is_PowerSeries`, `is_QuotientRing`
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
Part of:
- sagemath#32414
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
- Depends on sagemath#38151 (merged here)
URL: sagemath#38266
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 3, 2024
…nomialIdeal`, `is_MPolynomialRing`, `is_MPowerSeries`, `is_PolynomialQuotientRing`, `is_PolynomialRing`, `is_PolynomialSequence`, `is_PowerSeries`, `is_QuotientRing`
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
Part of:
- sagemath#32414
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
- Depends on sagemath#38151 (merged here)
URL: sagemath#38266
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38012
by not forcing input to be uni-variate if already uni-variate
📝 Checklist
⌛ Dependencies