Change inheritance order in UniqueRepresentation #38203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tscrim, @miguelmarco, can you complete the description? |
|
Documentation preview for this PR (built with commit 9adc348; changes) is ready! 🎉 |
|
Changed. You also need to remove the class here in order for the tests to pass. |
|
After a merge there are a couple of failing tests for |
|
The changed order looks like it is the correct thing given the change to the MRO we are making. |
tscrim
approved these changes
Jul 10, 2024
|
Thanks, as you said, beta0 is the right place. |
|
I understood that there was a positive review but the label has not been changed. |
|
Sorry, I thought I had changed it. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 25, 2024
<!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Currently in `UniqueRepresentation`, the MRO is constructed by ```class UniqueRepresentation(CachedRepresentation, WithEqualityById):``` However, in order to maximize the utility of the `WithEqualityById` class, in particular with subclasses of `UniqueRepresentation`, we should place it *first* in the MRO. This is useful in sagemath#37128, where this resolves MRO resolution issues and not having to reimplement (or set aliases) the behavior of `WithEqualityById`. However, this change, while seemingly innocuous, does cause a problem with one doctest dealing with very old pickles (Sage version <= 4.0) in `combinat/root_system/cartan_type.py` concerning `class CartanType_simple_finite:`. Currently, it is unclear why this change is resulting in the error: ``` sage: from sage.misc.fpickle import unpickleModule sage: pg_make_integer = unpickle_global('sage.rings.integer', 'make_integer') sage: si2 = pg_make_integer('4') sage: unpickle_build(si1, {'tools':unpickleModule('sage.combinat.root_system.type_A'), 't':['A', si2], 'letter':'A', 'n':si2}) Traceback (most recent call last): File "/sage/src/sage/doctest/forker.py", line 715, in _run self.compile_and_execute(example, compiler, test.globs) File "/sage/src/sage/doctest/forker.py", line 1147, in compile_and_execute exec(compiled, globs) File "<doctest sage.combinat.root_system.cartan_type.CartanType_simple _finite.__setstate__[5]>", line 1, in <module> unpickle_build(si1, {'tools':unpickleModule('sage.combinat.root_system.type_A'), 't':['A', si2], 'letter':'A', 'n':si2}) File "/sage/src/sage/misc/explain_pickle.py", line 2442, in unpickle_build setstate(state) File "/sage/src/sage/combinat/root_system/cartan_type.py", line 3106, in __setstate__ self.__class__ = T.__class__ TypeError: __class__ assignment: 'CartanType' object layout differs from 'CartanType_simple_finite' ``` However, since these are very old pickles and we cannot reproduce the failure otherwise, we feel that it is prudent to drop support for this and remove the corresponding class. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38203 Reported by: Enrique Manuel Artal Bartolo Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 31, 2024
<!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Currently in `UniqueRepresentation`, the MRO is constructed by ```class UniqueRepresentation(CachedRepresentation, WithEqualityById):``` However, in order to maximize the utility of the `WithEqualityById` class, in particular with subclasses of `UniqueRepresentation`, we should place it *first* in the MRO. This is useful in sagemath#37128, where this resolves MRO resolution issues and not having to reimplement (or set aliases) the behavior of `WithEqualityById`. However, this change, while seemingly innocuous, does cause a problem with one doctest dealing with very old pickles (Sage version <= 4.0) in `combinat/root_system/cartan_type.py` concerning `class CartanType_simple_finite:`. Currently, it is unclear why this change is resulting in the error: ``` sage: from sage.misc.fpickle import unpickleModule sage: pg_make_integer = unpickle_global('sage.rings.integer', 'make_integer') sage: si2 = pg_make_integer('4') sage: unpickle_build(si1, {'tools':unpickleModule('sage.combinat.root_system.type_A'), 't':['A', si2], 'letter':'A', 'n':si2}) Traceback (most recent call last): File "/sage/src/sage/doctest/forker.py", line 715, in _run self.compile_and_execute(example, compiler, test.globs) File "/sage/src/sage/doctest/forker.py", line 1147, in compile_and_execute exec(compiled, globs) File "<doctest sage.combinat.root_system.cartan_type.CartanType_simple _finite.__setstate__[5]>", line 1, in <module> unpickle_build(si1, {'tools':unpickleModule('sage.combinat.root_system.type_A'), 't':['A', si2], 'letter':'A', 'n':si2}) File "/sage/src/sage/misc/explain_pickle.py", line 2442, in unpickle_build setstate(state) File "/sage/src/sage/combinat/root_system/cartan_type.py", line 3106, in __setstate__ self.__class__ = T.__class__ TypeError: __class__ assignment: 'CartanType' object layout differs from 'CartanType_simple_finite' ``` However, since these are very old pickles and we cannot reproduce the failure otherwise, we feel that it is prudent to drop support for this and remove the corresponding class. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38203 Reported by: Enrique Manuel Artal Bartolo Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 2, 2024
<!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Currently in `UniqueRepresentation`, the MRO is constructed by ```class UniqueRepresentation(CachedRepresentation, WithEqualityById):``` However, in order to maximize the utility of the `WithEqualityById` class, in particular with subclasses of `UniqueRepresentation`, we should place it *first* in the MRO. This is useful in sagemath#37128, where this resolves MRO resolution issues and not having to reimplement (or set aliases) the behavior of `WithEqualityById`. However, this change, while seemingly innocuous, does cause a problem with one doctest dealing with very old pickles (Sage version <= 4.0) in `combinat/root_system/cartan_type.py` concerning `class CartanType_simple_finite:`. Currently, it is unclear why this change is resulting in the error: ``` sage: from sage.misc.fpickle import unpickleModule sage: pg_make_integer = unpickle_global('sage.rings.integer', 'make_integer') sage: si2 = pg_make_integer('4') sage: unpickle_build(si1, {'tools':unpickleModule('sage.combinat.root_system.type_A'), 't':['A', si2], 'letter':'A', 'n':si2}) Traceback (most recent call last): File "/sage/src/sage/doctest/forker.py", line 715, in _run self.compile_and_execute(example, compiler, test.globs) File "/sage/src/sage/doctest/forker.py", line 1147, in compile_and_execute exec(compiled, globs) File "<doctest sage.combinat.root_system.cartan_type.CartanType_simple _finite.__setstate__[5]>", line 1, in <module> unpickle_build(si1, {'tools':unpickleModule('sage.combinat.root_system.type_A'), 't':['A', si2], 'letter':'A', 'n':si2}) File "/sage/src/sage/misc/explain_pickle.py", line 2442, in unpickle_build setstate(state) File "/sage/src/sage/combinat/root_system/cartan_type.py", line 3106, in __setstate__ self.__class__ = T.__class__ TypeError: __class__ assignment: 'CartanType' object layout differs from 'CartanType_simple_finite' ``` However, since these are very old pickles and we cannot reproduce the failure otherwise, we feel that it is prudent to drop support for this and remove the corresponding class. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38203 Reported by: Enrique Manuel Artal Bartolo Reviewer(s): Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in
UniqueRepresentation, the MRO is constructed byclass UniqueRepresentation(CachedRepresentation, WithEqualityById):However, in order to maximize the utility of the
WithEqualityByIdclass, in particular with subclasses ofUniqueRepresentation, we should place it first in the MRO. This is useful in #37128, where this resolves MRO resolution issues and not having to reimplement (or set aliases) the behavior ofWithEqualityById.However, this change, while seemingly innocuous, does cause a problem with one doctest dealing with very old pickles (Sage version <= 4.0) in
combinat/root_system/cartan_type.pyconcerningclass CartanType_simple_finite:. Currently, it is unclear why this change is resulting in the error:However, since these are very old pickles and we cannot reproduce the failure otherwise, we feel that it is prudent to drop support for this and remove the corresponding class.
📝 Checklist
⌛ Dependencies