Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate global imports: GroupExp_Class, GroupExpElement, GroupSemidirectProductElement #38238

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Deprecate global imports: GroupExp_Class, GroupExpElement, GroupSemidirectProductElement #38238

merged 3 commits into from
Jul 24, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jun 18, 2024 •
edited
Loading

GroupExp_Class as discussed in:

Part of:

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@mkoeppe mkoeppe changed the title src/sage/groups/all.py: Deprecate import of GroupExp_Class, GroupExpE… Deprecate global imports: GroupExp_Class, GroupExpElement, GroupSemidirectProductElement Jun 18, 2024
@mkoeppe mkoeppe self-assigned this Jun 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

Documentation preview for this PR (built with commit a19d2de; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe mkoeppe marked this pull request as ready for review June 19, 2024 01:05
kwankyu
kwankyu approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kwankyu kwankyu mentioned this pull request Jun 19, 2024
Open
1 task
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 19, 2024

Thank you!

@vbraun vbraun merged commit 94d13a9 into sagemath:develop Jul 24, 2024
23 checks passed
@mkoeppe mkoeppe added this to the sage-10.5 milestone Jul 25, 2024
@mkoeppe mkoeppe deleted the GroupExp_deprecate_global branch July 25, 2024 09:32
mkoeppe added a commit to passagemath/passagemath that referenced this pull request Oct 29, 2024
@mkoeppe
src/sage/groups/all__sagemath_groups.py: Restore deprecation from sag…
a09b1e8 
…emath/sage#38238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

Assignees

@mkoeppe mkoeppe

Labels
c: group theory t: refactoring v: minimal
Projects
None yet
Milestone
sage-10.5
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoeppe @kwankyu @vbraun