-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide compatibility with numpy 2.0 #38250
Conversation
Documentation preview for this PR (built with commit 515d20e; changes) is ready! 🎉 |
Codecov complains about the lines |
I'm still getting a test failure:
|
that's one I don't quite know how to fix. |
Why is this even tested? I would understand if it was a numpy test, but a sage test? |
Nitpicking, the string "# to ensure numpy 2.0 compatibility" is applied inconsistently. I suggest for it to be attached to the "if" statement line. I guess it will be clear if an |
it's not really a test, it's more like part of a guide. Useful, but testing all its output isn't so important. I added |
WFM now |
I hope you're fine with undoing all that once numpy 2 becomes standard, see #38275 |
thanks! |
Well, I did not say to remove it altogether. But I absolutely know what you are saying. In time those compatibility hacks will go. |
it was just a trivial rebase |
Note: I've tested this PR using numpy 1.26 and using numpy 2.0 and it works fine on both cases. See void-linux/void-packages#49571 (comment). |
This will fix #38242
Basically, most of the problems are with numpy switching to a different way to display its data,
showing type. We either use a compatibility version, or add ellipses in doctests.
📝 Checklist
⌛ Dependencies