Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: Check that the build directory is on a normal writable file system #38256

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jun 22, 2024

Just another protection for users who skip reading the README

Fixes #38246

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

Documentation preview for this PR (built with commit df678bc; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe mkoeppe requested a review from seblabbe June 30, 2024 20:51
Copy link
Contributor

@seblabbe seblabbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When looking at the config.log file on the browser, I can confirm that the newly added lines works okay:

...
#25 19.63 config.status: creating directory local/share
#25 19.63 config.status: creating directory local/var/lib/sage/installed
#25 19.63 config.status: creating directory local/var/tmp/sage/build
#25 19.64 config.status: executing links commands
#25 19.64 config.status: creating convenience symlink prefix -> local
#25 19.64 config.status: creating convenience symlink venv -> local/var/lib/sage/venv-python3.10
...

@seblabbe
Copy link
Contributor

seblabbe commented Jul 3, 2024

The failing Lint test is related to other untouched files.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 8, 2024

Thank you!

@vbraun vbraun merged commit b6a5956 into sagemath:develop Jul 24, 2024
22 of 23 checks passed
@mkoeppe mkoeppe added this to the sage-10.5 milestone Jul 25, 2024
@mkoeppe mkoeppe deleted the configure_check_fs branch July 25, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configure: Refuse installation with --prefix in a bad file system
3 participants