Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor sage-spkg through sage-package #38271

Merged
merged 7 commits into from
Jul 24, 2024
Merged

Refactor sage-spkg through sage-package #38271

merged 7 commits into from
Jul 24, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jun 24, 2024 •
edited
Loading

Using the recently introduced command sage --package properties, we eliminate direct references to build/pkgs/ from the sage-spkg script.

Also simplifying build/make/Makefile.in by moving the handling of dummy packages to sage-spkg.

No user-visible changes.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Jun 24, 2024
@mkoeppe mkoeppe marked this pull request as ready for review June 24, 2024 23:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 24, 2024 •
edited
Loading

Documentation preview for this PR (built with commit a64573d; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe mkoeppe added this to the sage-10.5 milestone Jun 25, 2024
kwankyu
kwankyu approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 11, 2024

Thank you!

@vbraun vbraun merged commit 03bc844 into sagemath:develop Jul 24, 2024
31 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

Assignees

@mkoeppe mkoeppe

Labels
c: build t: refactoring v: moderate
Projects
None yet
Milestone
sage-10.5
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoeppe @kwankyu @vbraun