Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct eclib's m4 file code to check version #38284

Merged
merged 1 commit into from
Jul 24, 2024
Merged

correct eclib's m4 file code to check version #38284

merged 1 commit into from
Jul 24, 2024

Conversation

JohnCremona
Copy link
Member

Fixes #38283

📝 Checklist

  • [ x] The title is concise and informative.
  • [ x] The description explains in detail what this PR is about.
  • [ x] I have linked a relevant issue or discussion.

@JohnCremona JohnCremona requested a review from dimpase June 26, 2024 15:19
dimpase
dimpase approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 03247ad; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@vbraun vbraun merged commit 9363f84 into sagemath:develop Jul 24, 2024
34 of 42 checks passed
@JohnCremona JohnCremona deleted the eclib-m4 branch July 25, 2024 07:55
@mkoeppe mkoeppe added this to the sage-10.5 milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimpase dimpase dimpase approved these changes

Assignees
No one assigned
Labels
c: build: configure v: minimal
Projects
None yet
Milestone
sage-10.5
Development

Successfully merging this pull request may close these issues.

eclib m4 script incorrectly checks version
4 participants
@JohnCremona @dimpase @vbraun @mkoeppe