Implemented generators for some small graphs/ digraphs #38321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmenjayap
changed the title
|
Documentation preview for this PR (built with commit 1897136; changes) is ready! 🎉 |
|
For the |
dcoudert
suggested changes
Aug 4, 2024
|
don't forget to rebase your branch with the last develop version. |
dcoudert
suggested changes
Aug 7, 2024
dcoudert
reviewed
Aug 10, 2024
dcoudert
suggested changes
Aug 11, 2024
dcoudert
added
s: positive review
gsoc: 2024
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 27, 2024
<!-- ^ Please provide a concise and informative title. --> This PR adds generators for the Bicorn graph, the Tricorn graph, the Murty graph, the KohTindell digraph, the Cubeplex Graph and the Twinplex graph. <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> This PR introduces new static methods, specifically `BicornGraph`, `TricornGraph`, `MurtyGraph`, `KohTindellDiGraph`, `CubeplexGraph` and `TwinplexGraph`. <!-- v Why is this change required? What problem does it solve? --> There is no current implementation of the generators for the above mentioned graphs/ digraphs. <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Fixes sagemath#38320. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> Nothing as of now (up to my knowledge). <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> cc: @dcoudert. URL: sagemath#38321 Reported by: Janmenjaya Panda Reviewer(s): David Coudert, Janmenjaya Panda
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 19, 2024
<!-- ^ Please provide a concise and informative title. --> This PR adds generators for the Bicorn graph, the Tricorn graph, the Murty graph, the KohTindell digraph, the Cubeplex Graph and the Twinplex graph. <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> This PR introduces new static methods, specifically `BicornGraph`, `TricornGraph`, `MurtyGraph`, `KohTindellDiGraph`, `CubeplexGraph` and `TwinplexGraph`. <!-- v Why is this change required? What problem does it solve? --> There is no current implementation of the generators for the above mentioned graphs/ digraphs. <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Fixes sagemath#38320. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> Nothing as of now (up to my knowledge). <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> cc: @dcoudert. URL: sagemath#38321 Reported by: Janmenjaya Panda Reviewer(s): David Coudert, Janmenjaya Panda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds generators for the Bicorn graph, the Tricorn graph, the Murty graph, the KohTindell digraph, the Cubeplex Graph and the Twinplex graph.
This PR introduces new static methods, specifically
BicornGraph,TricornGraph,MurtyGraph,KohTindellDiGraph,CubeplexGraphandTwinplexGraph.There is no current implementation of the generators for the above mentioned graphs/ digraphs.
Fixes #38320.
📝 Checklist
⌛ Dependencies
Nothing as of now (up to my knowledge).
cc: @dcoudert.