Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement hypergeometric Euler factors at t=1 #38322

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

kedlaya
Copy link
Contributor

@kedlaya kedlaya commented Jul 1, 2024

Since #37881 was merged, we have the ability to compute hypergeometric traces at the degenerate value t=1. This PR makes a few changes to expose the corresponding functionality for Euler factors (again following the lead of Magma).

Copy link

github-actions bot commented Jul 1, 2024

Documentation preview for this PR (built with commit eb236ab; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpick details, which you could chose to ignore, but it is a while-we-are-at-it improvement to add links in the doc.

I don't know the math but I trust you with it (and there are no fundamental changes to the code).

src/sage/modular/hypergeometric_motive.py Outdated Show resolved Hide resolved
src/sage/modular/hypergeometric_motive.py Outdated Show resolved Hide resolved
@kedlaya kedlaya changed the title Implement Euler factors at t=1 Implement hypergeometric Euler factors at t=1 Jul 6, 2024
@tscrim
Copy link
Collaborator

tscrim commented Jul 8, 2024

Thank you. LGTM.

@vbraun vbraun merged commit 6e3c4ed into sagemath:develop Jul 24, 2024
22 checks passed
@mkoeppe mkoeppe added this to the sage-10.5 milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants