Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dimacs leaves junk files #38333

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Dimacs leaves junk files #38333

merged 2 commits into from
Jul 24, 2024

Conversation

seblabbe
Copy link
Contributor

@seblabbe seblabbe commented Jul 3, 2024

In the method DIMACS.__del__, we delete the temporary file created in the DIMACS.__init__ method.

This fixes #38328.

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

Documentation preview for this PR (built with commit 95a1e85; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

mezzarobba
mezzarobba approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@mezzarobba mezzarobba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@vbraun vbraun merged commit 08746ec into sagemath:develop Jul 24, 2024
20 of 21 checks passed
@mkoeppe mkoeppe added this to the sage-10.5 milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mezzarobba mezzarobba mezzarobba approved these changes

Assignees
No one assigned
Labels
v: minimal
Projects
None yet
Milestone
sage-10.5
Development

Successfully merging this pull request may close these issues.

DIMACS sat solver leaves junk files in /tmp folder
4 participants
@seblabbe @mezzarobba @vbraun @mkoeppe