Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EllipticCurve_with_prime_order() constructor #38341

Merged
merged 30 commits into from
Sep 15, 2024
Merged
Show file tree
Hide file tree
Changes from 26 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
d5bd34e
Implement algorithm 2.2 from BS2007 for EllipticCurve_with_prime_order()
JosePisco Jul 9, 2024
1767c5d
Changed $ sign for backticks in EllipticCurve_with_order() docstring
JosePisco Jul 9, 2024
f26730b
Docstring "NOTE::" block format
JosePisco Jul 9, 2024
1d8a783
Fixed to odd primes iteration and optimized their generation using pr…
JosePisco Jul 10, 2024
dd08f6c
Better wording for NOTE block in docstring
JosePisco Jul 10, 2024
95be4d8
Dynamic and precise bounds for the prime table at each round
JosePisco Jul 11, 2024
c84d6e6
Support python native int type
JosePisco Jul 11, 2024
4e78e2c
Improved latex formatting in NOTE docstring
JosePisco Jul 11, 2024
f2b9164
Blazingly fast optimization by filtering primes with kronecker symbol
JosePisco Aug 15, 2024
2e37e99
Perfect compliance with algorithm from paper
JosePisco Sep 4, 2024
9085cc9
Changing to iterator output
JosePisco Sep 6, 2024
36cb2af
factor out `has_order`
grhkm21 Sep 9, 2024
57cf88b
add extensive docs and gray code optimisation
grhkm21 Sep 9, 2024
bae2c84
use recursive implementation instead of gray code
grhkm21 Sep 9, 2024
bf706c5
fix docs
grhkm21 Sep 9, 2024
94c4866
remove bithack
grhkm21 Sep 10, 2024
459433c
add note about magic constant 1000
grhkm21 Sep 10, 2024
5fb4bc4
Coding style, naming and skip p=2
JosePisco Sep 10, 2024
d7d681a
fix things
grhkm21 Sep 10, 2024
2854e94
Apply suggestions from code review
grhkm21 Sep 11, 2024
4b9e197
apply review changes (explain ALGORITHM changes)
grhkm21 Sep 11, 2024
7941d8b
linter
grhkm21 Sep 11, 2024
43d5e40
Merge branch 'ecc-prime-order-BS2007' of github.com:JosePisco/sage in…
grhkm21 Sep 11, 2024
4840e9a
update test to use larger valued curves
grhkm21 Sep 11, 2024
e258c18
fix tests
grhkm21 Sep 11, 2024
c9e33ea
apply review changes
grhkm21 Sep 11, 2024
41cb6e9
use _order in has_order when possible
grhkm21 Sep 11, 2024
228a2bf
revert
grhkm21 Sep 11, 2024
163191f
apply review changes
grhkm21 Sep 11, 2024
b60e81f
apply review changes
grhkm21 Sep 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/doc/en/reference/references/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1326,6 +1326,9 @@ REFERENCES:
no. 1 (2003): 97-111,
http://www.moi.math.bas.bg/moiuser/~iliya/pdf_site/gf5srev.pdf.

.. [BS2007] \R. Bröker and P. Stevenhagen. *Constructing elliptic curves of
prime order*. [math.NT] (2007), :arXiv:`0712.2022`.

.. [BS2010] \P. Baseilhac and K. Shigechi. *A new current algebra and the
reflection equation*. Lett. Math. Phys. **92** (2010),
pp. 47-65. :arxiv:`0906.1482`.
Expand Down
2 changes: 1 addition & 1 deletion src/sage/schemes/elliptic_curves/all.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@
lazy_import('sage.schemes.elliptic_curves.jacobian', 'Jacobian')

lazy_import('sage.schemes.elliptic_curves.ell_finite_field', 'special_supersingular_curve')

lazy_import('sage.schemes.elliptic_curves.ell_rational_field',
['cremona_curves', 'cremona_optimal_curves'])

from sage.schemes.elliptic_curves.ell_finite_field import EllipticCurve_with_prime_order
from sage.schemes.elliptic_curves.cm import (cm_orders,
cm_j_invariants,
cm_j_invariants_and_orders,
Expand Down
Loading
Loading