Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/pkgs/ecm: Upgrade to 7.0.6 #38345

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jul 10, 2024

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

Documentation preview for this PR (built with commit 4eb1f6b; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@kwankyu
Copy link
Collaborator

kwankyu commented Jul 15, 2024

From the log of ./configure:

ecm:                            using system package; SPKG will not be installed

So Build&Test does not actually test sage with the upgraded package. This seems to be a defect in our CI. For real test, we should force installation of the upgraded spkg. Could this be fixed?

@kwankyu
Copy link
Collaborator

kwankyu commented Jul 15, 2024

Ah, the upgraded package was tested in CI Linux incremental.

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 17, 2024

So Build&Test does not actually test sage with the upgraded package.

That's right; if on this platform the system package can be used, this is what is done in the test.
This works as designed.

Ah, the upgraded package was tested in CI Linux incremental.

Yes.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 17, 2024

Thanks for the review!

@vbraun vbraun merged commit 78379ac into sagemath:develop Jul 24, 2024
37 of 44 checks passed
@mkoeppe mkoeppe added this to the sage-10.5 milestone Jul 25, 2024
@mkoeppe mkoeppe deleted the ecm-7.0.6-upgrade branch July 25, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants