Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated __repr__() to _repr_() in ideals classes #38346

Merged
merged 6 commits into from
Jul 24, 2024
Merged

Updated __repr__() to _repr_() in ideals classes #38346

merged 6 commits into from
Jul 24, 2024

Conversation

25shriya
Copy link
Contributor

@25shriya 25shriya commented Jul 10, 2024 •
edited
Loading

This PR aims at updating __repr__() method to _repr_(), in order to enable renaming and ensure consistency across various SageMath classes.
@tscrim

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@25shriya 25shriya changed the title Updated __repr__() to _repr_() in ideals classes Updated __repr__() to _repr_() in ideals classes Jul 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 5674225; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@tscrim
Copy link
Collaborator

tscrim commented Jul 15, 2024 •
edited
Loading

The __repr__ for QuotientMap and LiftMap cannot be changed (at this time) since they do not inherit from SageObject. That should take care of the doctest failures.

tscrim
tscrim approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM.

@vbraun vbraun merged commit 05fec04 into sagemath:develop Jul 24, 2024
24 checks passed
@mkoeppe mkoeppe added this to the sage-10.5 milestone Jul 25, 2024
@25shriya 25shriya mentioned this pull request Sep 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

Assignees
No one assigned
Labels
c: user interface t: refactoring
Projects
None yet
Milestone
sage-10.5
Development

Successfully merging this pull request may close these issues.
4 participants
@25shriya @tscrim @vbraun @mkoeppe