Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ncsf.py documentation #38372

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Update ncsf.py documentation #38372

merged 2 commits into from
Jul 24, 2024

Conversation

0-andy-0
Copy link
Contributor

@0-andy-0 0-andy-0 commented Jul 15, 2024

Correction lines 184-189: Psi is not the tensor algebra on the primitives but on the generators of this free Lie algebra.

Correction lines 184-189: Psi is not the tensor algebra on the primitives but on the generators of this free Lie algebra.

Fixes #38370

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Correction lines 184-189: Psi is not the tensor algebra on the primitives but on the generators of this free Lie algebra.
Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks

trailing whitespace removed
@fchapoton
Copy link
Contributor

thanks for removing the spaces

Copy link

Documentation preview for this PR (built with commit fc78fd0; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@0-andy-0
Copy link
Contributor Author

thanks for removing the spaces

Glad to help! Just a remark, I think I know how the error occured: probably modelled too closely on the documentation for the symmetric functions:

The graded connected bialgebra of symmetric functions over a algebra has a rather simply-understood structure: It is (isomorphic to) the symmetric algebra of its space of primitives

which is correct as the primitives are an abelian Lie algebra here 😄

@vbraun vbraun merged commit d868666 into sagemath:develop Jul 24, 2024
22 checks passed
@mkoeppe mkoeppe added this to the sage-10.5 milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation error in ncsf ?
4 participants