Call more general algorithm when lattice basis isn't trivial #38405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 261730a; changes) is ready! 🎉 |
mkoeppe
reviewed
Jul 25, 2024
|
Linter complaint seems unrelated to the PR: |
|
Yes, that is fixed by CI Fix #38423. |
mkoeppe
reviewed
Jul 26, 2024
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 31, 2024
…t trivial
fixes sagemath#38400
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.
URL: sagemath#38405
Reported by: Martin R. Albrecht
Reviewer(s): Martin R. Albrecht, Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 2, 2024
…t trivial
fixes sagemath#38400
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.
URL: sagemath#38405
Reported by: Martin R. Albrecht
Reviewer(s): Martin R. Albrecht, Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #38400